From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL afs: Development for 5.4
Date: Wed, 18 Sep 2019 17:22:54 -0700 [thread overview]
Message-ID: <CAHk-=wgJx0FKq5FUP85Os1HjTPds4B3aQwumnRJDp+XHEbVjfA@mail.gmail.com> (raw)
In-Reply-To: <16147.1568632167@warthog.procyon.org.uk>
On Mon, Sep 16, 2019 at 4:09 AM David Howells <dhowells@redhat.com> wrote:
>
> Here's a set of patches for AFS. The first three are trivial, deleting
> unused symbols and rolling out a wrapper function.
Pulled.
However, I was close to unpulling it again. It has a merge commit with
this merge message:
Merge remote-tracking branch 'net/master' into afs-next
and that simply is not acceptable.
Commit messages need to explain the commit. The same is even more true
of merges!
In a regular commit, you can at least look at the patch and say "ok,
that change is obvious and self-explanatory".
In a merge commit, the _only_ explanation you have is basically the
commit message, and when the commit message is garbage, the merge is
garbage.
If you can't explain why you are doing a merge, then you shouldn't do
the merge. It's that simple.
And if you can't be bothered to write the explanation down, I'm not
sure I can be bothered to then pull the end result.
Linus
next prev parent reply other threads:[~2019-09-19 0:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 11:09 [GIT PULL afs: Development for 5.4 David Howells
2019-09-19 0:22 ` Linus Torvalds [this message]
2019-09-19 0:24 ` Linus Torvalds
2019-09-19 1:55 ` pr-tracker-bot
2019-09-19 6:40 ` David Howells
2019-09-19 9:49 ` David Howells
2019-09-19 13:15 ` Matthew Wilcox
2019-09-19 14:03 ` Ilya Dryomov
2019-09-19 15:05 ` Jeffrey E Altman
2019-09-19 14:24 ` David Howells
2019-09-19 16:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgJx0FKq5FUP85Os1HjTPds4B3aQwumnRJDp+XHEbVjfA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).