From: Linus Torvalds <torvalds@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Samuel Dionne-Riel <samuel@dionne-riel.com>,
Oleg Nesterov <oleg@redhat.com>,
Richard Weinberger <richard.weinberger@gmail.com>,
Graham Christensen <graham@grahamc.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] exec: load_script: Allow interpreter argument truncation
Date: Thu, 14 Feb 2019 15:07:12 -0800 [thread overview]
Message-ID: <CAHk-=wgNt+Pm89Cqp5onH2dQN2ddAV-GU5ZftgrBpupx3h+juA@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jLYJyz+afGrMp_KbvL2xiwg3h6Cz_q6fQjXL9gpbej7QA@mail.gmail.com>
On Thu, Feb 14, 2019 at 10:10 AM Kees Cook <keescook@chromium.org> wrote:>
> We certainly can, but we'll still need to fix the "don't exec a
> truncated interpreter path" problem (which this fixes).
>
> I'm happy to do it as two steps instead: revert, then a separate fix
> to land in the merge window?
I think that's better. It should also be fairly easy: just look for
whitespace in the truncated output (in the place where we already
check for the "oh, we truncated")
It's even possible that somebody depends on a truncated interpreter
executable name. Unlikely, but possiible. So I'd rather just revert,
and re-try the smaller approach for 5.1.
Linus
prev parent reply other threads:[~2019-02-14 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:43 [PATCH v2] exec: load_script: Allow interpreter argument truncation Kees Cook
2019-02-14 17:46 ` Oleg Nesterov
2019-02-14 17:59 ` Linus Torvalds
2019-02-14 18:10 ` Kees Cook
2019-02-14 23:07 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgNt+Pm89Cqp5onH2dQN2ddAV-GU5ZftgrBpupx3h+juA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=graham@grahamc.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=oleg@redhat.com \
--cc=richard.weinberger@gmail.com \
--cc=samuel@dionne-riel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).