From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6EA5C433EF for ; Sun, 26 Jun 2022 20:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbiFZUzy (ORCPT ); Sun, 26 Jun 2022 16:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiFZUzv (ORCPT ); Sun, 26 Jun 2022 16:55:51 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32612DF3 for ; Sun, 26 Jun 2022 13:55:50 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id mf9so15243582ejb.0 for ; Sun, 26 Jun 2022 13:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OJgI0r/OP80N9dcPFjCLZLQisBcOF18myzMX4U+o7vY=; b=TqtTYTG1IxT0ubMo+gmUVYoa8uQ/KV90cCN6x8dihdGcq4c4m3JhdQfBdZiaB9c38W 6ji4Xh3GrVCWwS6EUkhuhilYtLLJeOl0H/BCci+5nOlRTRLdjU2PimbT5UY2ArhRfFpA JTbUB7StCoA9mrGxGCHyGp85ujKOBB0yR1XPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OJgI0r/OP80N9dcPFjCLZLQisBcOF18myzMX4U+o7vY=; b=GvOM8ISbMY7UtGuaw8tyqJ6X9NwHd823mOZ1FfPBT/bjGKnP/SG2+BZuikQOghrrsr I5ejI21z7gUoP3/WDgSrCNCP7SCZzzalBQIep8WBh4VT43rNPACsS6VGUzRlDdlaUR2B f4W77JhgBIx3PVMgrs4wlBjcivWQiawDOLTLXquhhAKVYb0ZLRkqm0o8xbLs6YZXaYup /4w50KQ73yskI3CLZGgp+08vLuWkKzgH99a4MEqknlTTTZW2V2NkWy24OOMFYkUyQi9y lHfjVQ8occmVFoshSN+ljleXapyMgrchlxpZTaf6fapGdXQZ+MD/UvqP6CS8y7bEJUzJ Ekkg== X-Gm-Message-State: AJIora9AwWCX/DuR9q6cGiRKx4kC3S1suvIBkW94aLe+DoOO24KbkMCF +vau/mJ7oIw67AwIRcHkUQ3zSDUjz6yzaaEx X-Google-Smtp-Source: AGRyM1t/+0EU5SzPDp4T9EaQt3rFHxLf1hNsJuJ2Q0kpYhW0f8FMvH0xouQ9/YjoCjBsniPq1rXFcQ== X-Received: by 2002:a17:906:9f0c:b0:712:1b55:37e1 with SMTP id fy12-20020a1709069f0c00b007121b5537e1mr9604827ejc.69.1656276949132; Sun, 26 Jun 2022 13:55:49 -0700 (PDT) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com. [209.85.221.46]) by smtp.gmail.com with ESMTPSA id l2-20020a170906078200b006fe89cafc42sm4192435ejc.172.2022.06.26.13.55.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 13:55:47 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id w17so10367681wrg.7 for ; Sun, 26 Jun 2022 13:55:46 -0700 (PDT) X-Received: by 2002:a05:6000:1f8d:b0:21b:aaec:ebae with SMTP id bw13-20020a0560001f8d00b0021baaecebaemr9680616wrb.274.1656276946496; Sun, 26 Jun 2022 13:55:46 -0700 (PDT) MIME-Version: 1.0 References: <874k0863x8.fsf@email.froward.int.ebiederm.org> <87pmiw1fy6.fsf@email.froward.int.ebiederm.org> <87ilonuti2.fsf_-_@email.froward.int.ebiederm.org> <871qvbutex.fsf_-_@email.froward.int.ebiederm.org> In-Reply-To: From: Linus Torvalds Date: Sun, 26 Jun 2022 13:55:30 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] kthread: Stop abusing TASK_UNINTERRUPTIBLE (INCOMPLETE) To: Tejun Heo Cc: "Eric W. Biederman" , Christian Brauner , Petr Mladek , Lai Jiangshan , Michal Hocko , Linux Kernel Mailing List , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Andrew Morton , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 26, 2022 at 1:23 PM Tejun Heo wrote: > > Would it be a reasonable tradeoff to have a kthread wrapper - > kthread_start() or whatever - which ensures that it is actually called > once on a new task? That way, we can keep the init code inline and > bugs on both sides (not starting and starting incorrectly) are > obvious. Yeah, that sounds reasonable to me. Linus