linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: Linux 4.20-rc6
Date: Mon, 10 Dec 2018 09:46:12 -0800	[thread overview]
Message-ID: <CAHk-=wgO2U0rGtLf-3Ym6dUKgavhNPZxHP7Gg8LuG8GgFaxKFA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vf6Au7yY4zdn5=qMjMvDKCi-LVAW45sjzB5f0C+m3VYHw@mail.gmail.com>

On Mon, Dec 10, 2018 at 1:52 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> Linus, due to my vacation schedule and possibility that Darren might
> be also busy with some stuff, would be okay to send PR this week, for
> example?

Oh, absolutely.

And I want to make it clear that this is not something you ever need
to even ask about, or make some "special case". It is absolutely
always true that any submaintainer can send pull requests for the next
merge window early.

To avoid any confusion, I do ask for a couple of simple things if you
send a pull request before the merge window opens:

 - make it very clear and _explicit_ in the pull request that this is
for the next merge window.

   In other words, don't make me unnecessarily upset about "this is
much too late in the rc series to send something this big" by making
it a small note at the end.

   This could still be something lik [GIT PULL] in the subject line,
but on the very first line say "For the next merge window" or
something. Don't make it subtle or something I might not notice before
I start getting upset at how big a pull request you're sending me
during rc6+.

 - don't use it as an excuse to send two or more bigger merge window
pulls. An early pull is not an excuse to then have a second big pull
with other changes.

   Second (and third) pulls are obviously fine, but they should either
be starting the calming-down period, or be about other things entirely
(some groups send 5-10 pull requests that are independent).

   I don't want to get the feeling that there is a "this is partial
work, there will be more" pattern.

Anyway, people have done this in the past, and I don't mind it at all.
Send pull requests early if they are all done and ready.

You don't even need to have a vacation excuse, you can just say "I'm
done, this is already in linux-next and it's passed testing etc, it's
not some unbaked thing that I just want to get rid of early"

                  Linus

  reply	other threads:[~2018-12-10 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-09 23:43 Linux 4.20-rc6 Linus Torvalds
2018-12-10  9:52 ` Andy Shevchenko
2018-12-10 17:46   ` Linus Torvalds [this message]
2018-12-10 18:39     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgO2U0rGtLf-3Ym6dUKgavhNPZxHP7Gg8LuG8GgFaxKFA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).