From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75533CA9EC2 for ; Mon, 28 Oct 2019 12:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BAC9204FD for ; Mon, 28 Oct 2019 12:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572266859; bh=UQUf8odpBOFLEZcbfj4CGQolighKZAidpUeRoDOYx7I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=oXCCBSwikF907KvNM4i29mHxYc30b8Qm5aT/kv/cPF+PZTzyighlzoimgnFAYHtvL rFU4+Ua9QnLxc4rXBaXRigcz8ezQ4EXWG39SKaV2ZiayQd89StN5j0/qXnLiXNvWZh YSYOxvA+OJfei0LSy+9noM9yZENioBx19koaF+wo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728192AbfJ1Mri (ORCPT ); Mon, 28 Oct 2019 08:47:38 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37167 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727316AbfJ1Mrh (ORCPT ); Mon, 28 Oct 2019 08:47:37 -0400 Received: by mail-lj1-f194.google.com with SMTP id l21so11191931lje.4 for ; Mon, 28 Oct 2019 05:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=43kMuxdcCYrw75OLEIGgvwzIRnKZbO0/qUIAHUs9fjA=; b=cSff5S6yI6dM9Egn5nfRqiok4k+70KNtQ3WNH3IFY088k4NXJ0NPflQG3OPr/taxkR xUEu/NkPtLE3zKEmQ7IjUCeeOc/9Hp5IaxSHYqvykCfrbI+eUodqR/b3+Jt0SEG2pKNN mNt1URIKmIq+awJoY+ucdy0NXoIrExTx+dTRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43kMuxdcCYrw75OLEIGgvwzIRnKZbO0/qUIAHUs9fjA=; b=Z7901D75mK9Bojy/HlErJppFyVvS6VgnyU4Ms3vHa2P78r5n2Ww0G39fdDU6EKpb5m r2dEhFe58xDe+VvHHYpPVX7/dcdfvjs1uRX/IjGk+RSk4keyhFoETA71lG/PseppQjUh 6Q6Zps+xAJfvMb4+4CP6NWDF9P9lq2aJlsqZaa4z3+cxeMeyuHSdzEIC0eXY6AlTPYhF WUj6Is0Epe+mD8IBvdGpMadHKECCc4vl7PTjh7ic8fRRxMVbBBHra2gem4yuciZA9XbS lJF8R0Zm78Nk6+7RE+0NvfF8E+0cshVBFlzWle434hCO46Aq0FPJjEPEg8ynZo8rB1PA A29Q== X-Gm-Message-State: APjAAAXeXAZXQD+kUAuRNW6w/WHdpiE7RuMayII1VOSG8IezbfJ3tAaf FI8Pyn1h6ZwPQRrnTAwH8NShMMDGPTBL1A== X-Google-Smtp-Source: APXvYqyBoTl4Wqb3qqyB3Q2iSe+pOrgQbZOnMzxA2PtCdjuiZVmMAI/cIEkNrkxbnwUQEN/Itzk7eA== X-Received: by 2002:a2e:547:: with SMTP id 68mr11796096ljf.150.1572266855011; Mon, 28 Oct 2019 05:47:35 -0700 (PDT) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id 77sm10092042lfj.41.2019.10.28.05.47.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2019 05:47:34 -0700 (PDT) Received: by mail-lj1-f182.google.com with SMTP id s4so10302890ljj.10 for ; Mon, 28 Oct 2019 05:47:33 -0700 (PDT) X-Received: by 2002:a05:651c:331:: with SMTP id b17mr11792488ljp.133.1572266853717; Mon, 28 Oct 2019 05:47:33 -0700 (PDT) MIME-Version: 1.0 References: <157225677483.3442.4227193290486305330.stgit@buzz> <20191028124222.ld6u3dhhujfqcn7w@box> In-Reply-To: <20191028124222.ld6u3dhhujfqcn7w@box> From: Linus Torvalds Date: Mon, 28 Oct 2019 13:47:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/filemap: do not allocate cache pages beyond end of file at read To: "Kirill A. Shutemov" Cc: Konstantin Khlebnikov , Linux-MM , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , Alexander Viro , Johannes Weiner , Steven Whitehouse Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 1:42 PM Kirill A. Shutemov wrote: > > I've tried something of this sort back in 2013: > > http://lore.kernel.org/r/1377099441-2224-1-git-send-email-kirill.shutemov@linux.intel.com > > and I've got push back. > > Apparently, some filesystems may not have valid i_size before >readpage(). > Not sure if it's still the case... Well, I agree that there might be some network filesystem that might have inode sizes that are stale, but if that's the case then I don't think your previous patch works either. It too will avoid the readpage() if the read position is beyond i_size. No? Linus