From: Linus Torvalds <torvalds@linux-foundation.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Linux 5.15-rc1
Date: Mon, 13 Sep 2021 12:51:30 -0700 [thread overview]
Message-ID: <CAHk-=wgUJe9rsM5kbmq7jLZc2E6N6XhYaeW9-zJgWaDC-wDiuw@mail.gmail.com> (raw)
In-Reply-To: <ab571d7e-0cf5-ffb3-6bbe-478a4ed749dc@gmail.com>
On Mon, Sep 13, 2021 at 12:00 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> With an older kernel you may experience the stall when accessing the vpd
> attribute of this device in sysfs.
Honestly, that old behavior seems to be the *much* better behavior.
A synchronous stall at boot time is truly annoying, and a pain to deal
with (and debug).
That pci_vpd_read() function is clearly NOT designed to deal with
boot-time callers in the first place, so I think that commit is simply
wrong.
And yes, I see that "128ms timeout". If it was _one_ timeout, that
would be one thing,. But it looks like it's repeated over and over.
Not acceptable at boot time. Not at all.
Bjorn. Please revert. Or I can do it.
Linus
next prev parent reply other threads:[~2021-09-13 19:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 23:58 Linux 5.15-rc1 Linus Torvalds
2021-09-13 3:57 ` Guenter Roeck
2021-09-28 23:18 ` Michael S. Tsirkin
2021-09-30 13:44 ` Guenter Roeck
2021-09-13 14:18 ` Dave Jones
2021-09-13 18:59 ` Heiner Kallweit
2021-09-13 19:51 ` Linus Torvalds [this message]
2021-09-13 20:09 ` Bjorn Helgaas
2021-09-13 20:11 ` Heiner Kallweit
2021-09-13 20:15 ` Linus Torvalds
2021-09-13 20:15 ` Dave Jones
2021-09-13 20:22 ` Heiner Kallweit
2021-09-13 20:32 ` Dave Jones
2021-09-13 20:44 ` Linux 5.15-rc1 - 82599ES VPD access isue Heiner Kallweit
2021-09-13 23:32 ` [Intel-wired-lan] " Hisashi T Fujinaka
2021-09-14 5:51 ` Heiner Kallweit
2021-09-14 14:24 ` Dave Jones
2021-09-14 18:28 ` Fujinaka, Todd
2021-09-14 20:00 ` Hisashi T Fujinaka
2021-09-14 21:51 ` Heiner Kallweit
2021-09-15 14:18 ` Hisashi T Fujinaka
2021-09-15 16:05 ` Heiner Kallweit
2021-09-15 16:16 ` Hisashi T Fujinaka
2021-09-15 22:32 ` Bjorn Helgaas
2021-09-15 23:46 ` Hisashi T Fujinaka
2021-09-17 15:09 ` Bjorn Helgaas
2021-09-13 20:32 ` Linux 5.15-rc1 Heiner Kallweit
2021-09-13 20:36 ` Linus Torvalds
2021-09-13 20:41 ` Dave Jones
2021-09-13 23:46 ` Bjorn Helgaas
2021-09-14 0:39 ` Dave Jones
2021-09-14 6:21 ` Heiner Kallweit
2021-09-14 11:26 ` Bjorn Helgaas
2021-09-14 17:07 ` Heiner Kallweit
2021-09-14 21:55 ` Bjorn Helgaas
2021-09-14 22:06 ` Heiner Kallweit
2021-09-14 22:33 ` Dave Jones
2021-09-15 21:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgUJe9rsM5kbmq7jLZc2E6N6XhYaeW9-zJgWaDC-wDiuw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=davej@codemonkey.org.uk \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).