From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Brown <broonie@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
linux-next@vger.kernel.org, mhocko@suse.cz,
mm-commits@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: mmotm 2019-04-19-14-53 uploaded (objtool)
Date: Tue, 23 Apr 2019 09:19:50 -0700 [thread overview]
Message-ID: <CAHk-=wg_yKXPmkTcHWPsf61BXNLzz9bEUDWboN4QfeHKZsCoXA@mail.gmail.com> (raw)
In-Reply-To: <20190423082448.GY11158@hirez.programming.kicks-ass.net>
On Tue, Apr 23, 2019 at 1:25 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> Now, we could of course allow this symbol, but I found only the below
> was required to make allyesconfig build without issue.
>
> Andy, Linus?
Ack on that patch. Except I think the uaccess.h part should be a
separate commit: I think it goes along with 2a418cf3f5f1
("x86/uaccess: Don't leak the AC flag into __put_user() value
evaluation") we did earlier. I think the logic is the same - it's not
just the _value_ that can have complex calculations, the address can
too (although admittedly that's really not supposed to be common, but
you clearly found one case where a complier misfeature made it happen,
so...).
I also wonder if we should just make "count" be "unsigned long" in
do_{strncpy_from,strnlen}_user() too, since we've already done
if (unlikely(count <= 0))
return 0;
in the caller, so it *is* unsigned by then, and we'd not be mixing
signedness when comparing "max/count/res".
Linus
next prev parent reply other threads:[~2019-04-23 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 21:53 mmotm 2019-04-19-14-53 uploaded akpm
2019-04-20 4:36 ` mmotm 2019-04-19-14-53 uploaded (objtool) Randy Dunlap
2019-04-23 8:24 ` Peter Zijlstra
2019-04-23 15:45 ` Randy Dunlap
2019-04-23 16:07 ` Andy Lutomirski
2019-04-23 17:39 ` Peter Zijlstra
2019-04-23 18:57 ` Peter Zijlstra
2019-04-23 16:19 ` Linus Torvalds [this message]
2019-04-23 17:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg_yKXPmkTcHWPsf61BXNLzz9bEUDWboN4QfeHKZsCoXA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).