From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
arseny.krasnov@kaspersky.com, caihuoqing@baidu.com,
elic@nvidia.com, Jason Wang <jasowang@redhat.com>,
lingshan.zhu@intel.com, mgurtovoy@nvidia.com,
Viresh Kumar <viresh.kumar@linaro.org>,
Will Deacon <will@kernel.org>, Wolfram Sang <wsa@kernel.org>,
xianting.tian@linux.alibaba.com, xieyongji@bytedance.com
Subject: Re: [GIT PULL] virtio,vdpa,vhost: features, fixes
Date: Sat, 11 Sep 2021 14:56:12 -0700 [thread overview]
Message-ID: <CAHk-=wgcXzshPVvVgGDqa9Y9Sde6RsUvj9jvx0htBqPuaTGX4Q@mail.gmail.com> (raw)
In-Reply-To: <20210909095608-mutt-send-email-mst@kernel.org>
On Thu, Sep 9, 2021 at 6:56 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> NB: when merging this with
> b542e383d8c0 ("eventfd: Make signal recursion protection a task bit")
> from Linus' tree, replace eventfd_signal_count with
> eventfd_signal_allowed, and drop the export of eventfd_wake_count from
> ("eventfd: Export eventfd_wake_count to modules").
What? No. That can't be right.
Do you mean "replace eventfd_signal_count with !eventfd_signal_allowed()"?
Because if I read the logic correctly, the issue is that
'vduse_vq_kick()' will call eventfd_signal().
Which it must not do it eventfd_signal_allowed() returns false.
So if eventfd_signal_allowed() is _not_ set, the code needs to defer
it to the workqueue.
No?
Side note: I was _this_ close to just not pulling this. The commits
were all from after the merge window opened, and I got this pull
request in the latter half of the second week of the merge window.
Your "explanations" for this pull are also not any language I
recognize, or even remotely human-readable.
WTF does "vduse driver supporting blk" mean, and how is that supposed
to explain anything at all?
That is NOT how these things are supposed to work. AT ALL.
So you are hereby put on notice: next time I get this kind of
half-arsed garbage pull request, I won't spend the energy on trying to
figure out what is actually going on. I will just throw it in the
trash.
Because honestly, that's where this pull request belonged.
Linus
next prev parent reply other threads:[~2021-09-11 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:56 [GIT PULL] virtio,vdpa,vhost: features, fixes Michael S. Tsirkin
2021-09-11 21:56 ` Linus Torvalds [this message]
2021-09-11 23:51 ` Yongji Xie
2021-09-12 0:11 ` Michael S. Tsirkin
2021-09-12 0:43 ` Linus Torvalds
2021-09-12 0:42 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgcXzshPVvVgGDqa9Y9Sde6RsUvj9jvx0htBqPuaTGX4Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arseny.krasnov@kaspersky.com \
--cc=caihuoqing@baidu.com \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=wsa@kernel.org \
--cc=xianting.tian@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).