From: Linus Torvalds <torvalds@linux-foundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [GIT PULL] Kbuild fixes for v5.19-rc4
Date: Sun, 26 Jun 2022 11:19:40 -0700 [thread overview]
Message-ID: <CAHk-=wgcsUU-TNoLS7Q6YF3RCSVAKwNM7gFOwqnPQTiU_oGEWA@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARjq-x+8rdXfkVt2YEoJsjnZNntxurYTwOqEaAX71m04w@mail.gmail.com>
On Sat, Jun 25, 2022 at 3:16 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Please pull a couple of Kbuild fixes.
Masahiro, I already complained about this once:
Section mismatch in reference from the variable .. declared __init
and now you re-introduced this sneakily by just putting it in another place.
I told you last time that you need to *FIX* these things before adding
the warning, instead of adding a warning and then waiting for others
to fix them.
Yes, it's fixing an earlier mistake, but that earlier mistake is over
a decade old by now.
Now, the only warning that seems to show up for me is about
tick_nohz_full_setup. Which is only called from housekeeping_setup()
in kernel/sched/isolation.c if I grepped correctly.
And that seems only ever built-in as far as I can tell, so the whole
export seems pointless, and the fix is presumably to remove the
export_SYMBOL_GPL entirely.
So it seems fixable.
But I'm upset about this sneaking in when we _talked_ about this issue earlier.
Paul - that export was added by commit ae9e557b5be2 ("time: Export
tick start/stop functions for rcutorture"), and it seems to have been
bogus even at that time.
Linus
next prev parent reply other threads:[~2022-06-26 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 22:15 [GIT PULL] Kbuild fixes for v5.19-rc4 Masahiro Yamada
2022-06-26 17:36 ` pr-tracker-bot
2022-06-26 18:19 ` Linus Torvalds [this message]
2022-06-27 1:09 ` Masahiro Yamada
2022-06-27 7:36 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgcsUU-TNoLS7Q6YF3RCSVAKwNM7gFOwqnPQTiU_oGEWA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).