From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: kernel test robot <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Ajay Kaher <ajay.kaher@broadcom.com>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address
Date: Mon, 29 Jan 2024 14:19:56 -0800 [thread overview]
Message-ID: <CAHk-=wgcy_8snS3znhTB2M_=rDg5gy8bQunKvhLse=AVPp6rOg@mail.gmail.com> (raw)
In-Reply-To: <20240129164522.72482faa@gandalf.local.home>
On Mon, 29 Jan 2024 at 13:45, Steven Rostedt <rostedt@goodmis.org> wrote:
> > 1 file changed, 50 insertions(+), 219 deletions(-)
>
> Thanks, much appreciated.
Well, I decided I might as well give it a test-run, and there's an
immediate deadlock on eventfs_mutex, because I missed removing it from
eventfs_find_events() when the callers now already hold it.
So at a minimum, it will require this patch on top:
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -230,7 +230,6 @@ static struct eventfs_inode
*eventfs_find_events(
{
struct eventfs_inode *ei;
- mutex_lock(&eventfs_mutex);
do {
// The parent is stable because we do not do renames
dentry = dentry->d_parent;
@@ -247,7 +246,6 @@
}
// Walk upwards until you find the events inode
} while (!ei->is_events);
- mutex_unlock(&eventfs_mutex);
update_top_events_attr(ei, dentry->d_sb);
to not deadlock immediately on the first lookup.
And honestly, there might be other such obvious "I missed that when
reading the code".
Let me reboot into a fixed system and do some more basic smoke-testing.
Linus
next prev parent reply other threads:[~2024-01-29 22:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 2:58 [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address kernel test robot
2024-01-29 4:36 ` Linus Torvalds
2024-01-29 17:01 ` Steven Rostedt
2024-01-29 17:40 ` Linus Torvalds
2024-01-29 17:44 ` Steven Rostedt
2024-01-29 17:45 ` Steven Rostedt
2024-01-29 17:56 ` Linus Torvalds
2024-01-29 17:55 ` Linus Torvalds
2024-01-29 19:24 ` Linus Torvalds
2024-01-29 19:51 ` Linus Torvalds
2024-01-29 20:26 ` Steven Rostedt
2024-01-29 20:51 ` Linus Torvalds
2024-01-29 21:45 ` Steven Rostedt
2024-01-29 22:19 ` Linus Torvalds [this message]
2024-01-29 21:55 ` Steven Rostedt
2024-01-29 22:22 ` Steven Rostedt
2024-01-29 22:35 ` Linus Torvalds
2024-01-29 22:42 ` Linus Torvalds
2024-01-29 22:49 ` Steven Rostedt
2024-01-30 0:01 ` Linus Torvalds
2024-01-30 0:35 ` Steven Rostedt
2024-01-30 1:50 ` Linus Torvalds
2024-01-30 3:56 ` Linus Torvalds
2024-01-30 8:43 ` Linus Torvalds
2024-01-30 9:12 ` Linus Torvalds
2024-01-30 12:45 ` Rasmus Villemoes
2024-01-30 14:39 ` Steven Rostedt
2024-01-30 16:49 ` Steven Rostedt
2024-01-30 16:55 ` Linus Torvalds
2024-01-30 17:06 ` Steven Rostedt
2024-01-30 17:09 ` Linus Torvalds
2024-01-30 16:51 ` Linus Torvalds
2024-01-30 18:23 ` Steven Rostedt
2024-01-30 19:19 ` Linus Torvalds
2024-01-30 19:37 ` Steven Rostedt
2024-01-30 19:54 ` Linus Torvalds
2024-01-30 20:04 ` Steven Rostedt
2024-01-31 15:58 ` Steven Rostedt
2024-01-31 16:13 ` Steven Rostedt
2024-01-31 17:28 ` Steven Rostedt
2024-01-31 17:26 ` Steven Rostedt
2024-01-31 19:35 ` Linus Torvalds
2024-01-31 19:42 ` Steven Rostedt
2024-01-30 18:36 ` Steven Rostedt
2024-01-29 22:47 ` Steven Rostedt
2024-01-29 23:15 ` Steven Rostedt
2024-01-30 2:08 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgcy_8snS3znhTB2M_=rDg5gy8bQunKvhLse=AVPp6rOg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ajay.kaher@broadcom.com \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).