From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CBEC433E2 for ; Mon, 14 Sep 2020 22:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEFA6206BE for ; Mon, 14 Sep 2020 22:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600124397; bh=IZs8WBVAqJ6Oqa3Ii/7jKrCADkTwpntBTm5n7KY7qDo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=pYa8MZA6pYhhwOvgKCw2SasAMCrSX+WRJAXKCPKa7gC9Z9Sl331RTUkLOSMTUKG9I S0i+QmT8hHW5KCS0fQV4Ae/o6uRQ7xhhb3OSG80kqNM2VM+UDkyXmy0QcrkD8Ys43o 37EWV+RPKjMtFCk8LZgx0qdclne/lqQn/kKYrx6k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgINW74 (ORCPT ); Mon, 14 Sep 2020 18:59:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgINW7w (ORCPT ); Mon, 14 Sep 2020 18:59:52 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 121CDC06174A for ; Mon, 14 Sep 2020 15:59:52 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id b12so1015591lfp.9 for ; Mon, 14 Sep 2020 15:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2G/hRodaEbdwMTJFpgACQrYpQlQOkpSJnW9fYCTn//U=; b=P2zwY7nDqwbuhESYBJOt1I5qmdHytgOKwp422wQetkvqkPjEYwKyETCI9Liciynnql +LRT09+Z5sFr23gNmEfkesJnuBCjjAx188+w1PEfPjFqavBZzukRtc2pwBD4XSgKnVbq U11bfkaeAq7pNwAN2Dbw8dBEQ22pJBXPQNi4I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2G/hRodaEbdwMTJFpgACQrYpQlQOkpSJnW9fYCTn//U=; b=SqhETzHHkOxyFy4ErYa/lHsrBOt07iP3tCqa9EUpSksR3wZIDaTwhRt/ouhBtV5qMj zvCDfFzG5m9y4imdh+LP0E0lY5tg0VIe9MHU6EOUdftn/ptQ8MIoQ+aQU2GDYiDttcmQ aWE3RYPiayt1zi8c5lHnvwpOj69G7gE/MKCjurFPUuHxlBmN8w8+AHyvtxNsaBfcvASO F6kQFaPf3JGiIZLrJLRk1zjtnT6+v6LQHpv9QrZm2VkBXOEiTHDcDrLLQ0VjDIQCB2Hx zIffsM9Wbc5tLjh64MyAxK3PkGNJCQgo17TEQvYYg0EKSjnDkqUWE7jmR9eako/e0b/y It3w== X-Gm-Message-State: AOAM530+w/zJEMsKs1ATw3Y1RLm97vUiLzx8BtDJwgW0U98UlGbP5x2e bNodIG/Hoh05Hu2H1c7Z+/Ky+9KtA1Shtg== X-Google-Smtp-Source: ABdhPJzK8X+QNYp9TY4JMc4gQTHpTHTrzgHQpdpaeh0Lpdk2n7JeKDIuvVxD3N+lknY00xB2v0GiOQ== X-Received: by 2002:a19:604e:: with SMTP id p14mr4820448lfk.385.1600124389959; Mon, 14 Sep 2020 15:59:49 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id o3sm3570319lfb.168.2020.09.14.15.59.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 15:59:48 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id m5so1031879lfp.7 for ; Mon, 14 Sep 2020 15:59:47 -0700 (PDT) X-Received: by 2002:ac2:4ec7:: with SMTP id p7mr4498792lfr.352.1600124387573; Mon, 14 Sep 2020 15:59:47 -0700 (PDT) MIME-Version: 1.0 References: <20200821234958.7896-1-peterx@redhat.com> <20200821234958.7896-2-peterx@redhat.com> <20200914143829.GA1424636@nvidia.com> <20200914183436.GD30881@xz-x1> <20200914211515.GA5901@xz-x1> <20200914225542.GO904879@nvidia.com> In-Reply-To: <20200914225542.GO904879@nvidia.com> From: Linus Torvalds Date: Mon, 14 Sep 2020 15:59:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] mm: Trial do_wp_page() simplification To: Jason Gunthorpe Cc: Peter Xu , Leon Romanovsky , Linux-MM , Linux Kernel Mailing List , "Maya B . Gokhale" , Yang Shi , Marty Mcfadden , Kirill Shutemov , Oleg Nesterov , Jann Horn , Jan Kara , Kirill Tkhai , Andrea Arcangeli , Christoph Hellwig , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 3:55 PM Jason Gunthorpe wrote: > > Just as an aside, the RDMA stuff is also supposed to set MADV_DONTFORK > on these regions, so I'm a bit puzzled what is happening here. Did the fork perhaps happen _before_ , so the pages are shared when you do the pin? MADV_DONTFORK doesn't mean COW doesn't happen. It just means that the next fork() won't be copying that memory area. That said, it's possible that the test cases do something invalid - or maybe we've broken MADV_DONTFORK - and it all just happened to work before. So it's possible the breakage is exposing some other bug.. Linus