From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A1DC433EF for ; Thu, 12 May 2022 17:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356919AbiELRMD (ORCPT ); Thu, 12 May 2022 13:12:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356930AbiELRLB (ORCPT ); Thu, 12 May 2022 13:11:01 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F115727FD7 for ; Thu, 12 May 2022 10:10:56 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id bv19so11524982ejb.6 for ; Thu, 12 May 2022 10:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=loonHWmCtVeGx4aWVVUzPzapZ1t+QIqGsKXmCgmw6z8=; b=WD5qjD3n7PQ6Q1+OHYaSBYIXZyE3MSnd14hOsae1gMnqzXVow2TJFjREwN777Ig52q V4qfULfCcQ86ni9aAhSi7LjMQHCPkFJi+glv65R1S+sQR6oFUNEhVyq5JADGgBm6h1kT 2hznSR7F9VZ12haH7nWz1Ev8hTm8abuX+I6D4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=loonHWmCtVeGx4aWVVUzPzapZ1t+QIqGsKXmCgmw6z8=; b=fB21s0bz0sorJAx4QzsaITGMVTsVzPYWIo3BwbmRIjs8i/gM3pm0+k7VE3i8VO4+20 DSWiLsAWjdqcSWA+yaMq0KsP+AAddUfoWdWXnRw0jcyB604EpTfylc6vO6nE+jyDMRRu rtUqhGf+Wp3BZm7igDvfFR+M6dg0BihkDtqif3Fa3I1d/ZknI5azujoPyfE2gZ27XANv 6kCHyXobeFJK/88Tqvy0Wfb+6qYWd9gafy5noQunOqYiQowLbtJwTItoLPRvhKhkbPO+ OLRykOPGcYpu0Xana8ddSPSJ55M0tkd3KHZ725a5cYJ4jHVDireogMheGoXcgno57I1S Tcnw== X-Gm-Message-State: AOAM531RDlwWEHU8u0aO+th2kW3Aa6YfGuIKvqT95EhWys7sANMHCTwF THAeU9ZE+QrFEUrJMpfzkZwfnnzrm/OGZcz5HpA= X-Google-Smtp-Source: ABdhPJxDN6Hwhpo+ubYFdrhDW/6nWDfS/q/cQEARq7g11BvGA9uxioGKI5LNxvmbneDAucdR+OsBnQ== X-Received: by 2002:a17:907:2159:b0:6f3:a307:d01d with SMTP id rk25-20020a170907215900b006f3a307d01dmr803565ejb.760.1652375454338; Thu, 12 May 2022 10:10:54 -0700 (PDT) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com. [209.85.221.50]) by smtp.gmail.com with ESMTPSA id eg56-20020a05640228b800b00427ae00972dsm2892281edb.12.2022.05.12.10.10.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 10:10:52 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id d5so8169531wrb.6 for ; Thu, 12 May 2022 10:10:51 -0700 (PDT) X-Received: by 2002:a05:6000:2c2:b0:20c:7329:7c10 with SMTP id o2-20020a05600002c200b0020c73297c10mr557896wry.193.1652375451235; Thu, 12 May 2022 10:10:51 -0700 (PDT) MIME-Version: 1.0 References: <20220510082351-mutt-send-email-mst@kernel.org> <87czgk8jjo.fsf@mpe.ellerman.id.au> <87mtfm7uag.fsf@mpe.ellerman.id.au> In-Reply-To: <87mtfm7uag.fsf@mpe.ellerman.id.au> From: Linus Torvalds Date: Thu, 12 May 2022 10:10:34 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] virtio: last minute fixup To: Michael Ellerman Cc: "Michael S. Tsirkin" , Konstantin Ryabitsev , KVM list , virtualization@lists.linux-foundation.org, Netdev , Linux Kernel Mailing List , mie@igel.co.jp Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 6:30 AM Michael Ellerman wrote: > > Links to other random places don't serve that function. What "function"? This is my argument. Those Link: things need to have a *reason*. Saying "they are a change ID" is not a reason. That's just a random word-salad. You need to have an active reason that you can explain, not just say "look, I want to add a message ID to every commit". Here's the thing. There's a difference between "data" and "information". We should add information to the commits, not random data. And most definitely not just random data that can be trivially auto-generated after-the-fact. Linus