linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Harry Wentland <harry.wentland@amd.com>,
	Leo Li <sunpeng.li@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Balbir Singh <bsingharora@gmail.com>,
	Daniel Axtens <dja@axtens.net>,
	Paul Mackerras <paulus@ozlabs.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: Linux 5.19-rc6
Date: Thu, 14 Jul 2022 09:48:36 -0700	[thread overview]
Message-ID: <CAHk-=wgnmaTVigBc02tjqgcZaNJiYz8Xw77P+ERAXhcYjkwd=Q@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdV9Pj9V-ZPpu=BMSkPt1uA_eCvU4+bxF8ZfHjteRk2CAg@mail.gmail.com>

On Thu, Jul 14, 2022 at 12:23 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Oh, it's not just this one. The lists of build regressions between v5.18
> and v5.19-rc1 [1] resp. v5.19-rc6 [2] look surprisingly similar :-(
>
> [1] https://lore.kernel.org/all/20220606082201.2792145-1-geert@linux-m68k.org
> [2] https://lore.kernel.org/all/20220711064425.3084093-1-geert@linux-m68k.org

Hmm.

Some of them are because UM ends up defining and exposing helper
functions like "to_phys()", which it just shouldn't do. Very generic
name - so when some driver ends up using the same name, you get those
errors.

And some look positively strange. Like that

  drivers/mfd/asic3.c: error: unused variable 'asic'
[-Werror=unused-variable]:  => 941:23

which is clearly used three lines later by

        iounmap(asic->tmio_cnf);

and I can't find any case of 'iounmap()' having been defined to an
empty macro or anything like that to explain it. The error in
drivers/tty/serial/sh-sci.c looks to be exactly the same issue, just
with ioremap() instead of iounmap().

It would be good to have some way to find which build/architecture it
is, because right now it just looks bogus.

Do you perhaps use some broken compiler that complains when the empty
inline functions don't use their arguments? Because that's what those
ioremap/iounmap() ones look like to me, but there might be some
magical architecture / config that has issues that aren't obvious.

IOW, I'd love to get those fixed, but I would also want a little bit more info.

            Linus

  parent reply	other threads:[~2022-07-14 16:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10 21:54 Linux 5.19-rc6 Linus Torvalds
2022-07-11  6:44 ` Build regressions/improvements in v5.19-rc6 Geert Uytterhoeven
2022-07-13  5:07 ` Linux 5.19-rc6 Guenter Roeck
2022-07-13 19:36   ` Linus Torvalds
2022-07-13 19:48     ` Russell King (Oracle)
2022-07-13 20:21       ` Linus Torvalds
2022-07-13 20:40         ` Guenter Roeck
2022-07-13 20:42           ` Linus Torvalds
2022-07-14 12:20             ` Russell King (Oracle)
2022-07-14 12:14           ` Russell King (Oracle)
2022-07-13 21:36         ` Sudip Mukherjee
2022-07-13 21:45           ` Linus Torvalds
2022-07-13 21:50             ` Sudip Mukherjee
2022-07-13 22:56               ` Guenter Roeck
2022-07-13 23:09                 ` Sudip Mukherjee
2022-07-13 23:12                   ` Guenter Roeck
2022-07-13 23:26                     ` Sudip Mukherjee
2022-07-13 23:44                       ` Guenter Roeck
2022-07-13 23:02               ` Guenter Roeck
2022-07-14  1:30       ` Kefeng Wang
2022-07-13 19:53     ` Alex Deucher
2022-07-13 20:22       ` Linus Torvalds
2022-07-13 20:45         ` Guenter Roeck
2022-07-13 20:46     ` Guenter Roeck
2022-07-13 20:50       ` Linus Torvalds
2022-07-13 21:00       ` Alex Deucher
2022-07-13 21:32         ` Linus Torvalds
2022-07-14  7:23           ` Geert Uytterhoeven
2022-07-14 13:20             ` Guenter Roeck
2022-07-14 13:56               ` Geert Uytterhoeven
2022-07-14 16:48             ` Linus Torvalds [this message]
2022-07-14 17:24               ` Guenter Roeck
2022-07-14 17:37                 ` Linus Torvalds
2022-07-15  7:26                 ` Geert Uytterhoeven
2022-07-14 16:52           ` Alex Deucher
2022-07-14 23:16           ` Russell Currey
2022-07-15  9:33             ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgnmaTVigBc02tjqgcZaNJiYz8Xw77P+ERAXhcYjkwd=Q@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bsingharora@gmail.com \
    --cc=dja@axtens.net \
    --cc=geert@linux-m68k.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@ozlabs.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sunpeng.li@amd.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).