From: Linus Torvalds <torvalds@linux-foundation.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Mark Brown <broonie@kernel.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Brendan Higgins <brendanhiggins@google.com>,
Anders Roxell <anders.roxell@linaro.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Kselftest update for Linux 5.4-rc1
Date: Fri, 20 Sep 2019 09:17:53 -0700 [thread overview]
Message-ID: <CAHk-=wgs+UoZWfHGENWSVBd57Z-Vp0Nqe68R6wkDb5zF+cfvDg@mail.gmail.com> (raw)
In-Reply-To: <be8059f4-8e8f-cd18-0978-a9c861f6396b@linuxfoundation.org>
On Tue, Sep 17, 2019 at 12:26 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> This Kselftest update for Linux 5.4-rc1 consists of several fixes to
> existing tests and adds KUnit, a lightweight unit testing and mocking
> framework for the Linux kernel from Brendan Higgins.
So I pulled this, but then I almost immediately unpulled it.
My reason for doing that may be odd, but it's because of the top-level
'kunit' directory. This shouldn't be on the top level.
The reason I react so strongly is that it actually breaks my finger
memory. I don't type out filenames - I auto-compete them. So "kernel/"
is "k<tab>", "drivers/" is "d<tab>" etc.
It already doesn't work for everything ("mm/" is actually "mm<tab>"
not because we have files in the git tree, but because the build
creates various "module" files), but this breaks a common pattern for
me.
> In the future KUnit will be linked to Kselftest framework to provide
> a way to trigger KUnit tests from user-space.
Can the kernel parts please move to lib/kunit/ or something like that?
Linus
next prev parent reply other threads:[~2019-09-20 16:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 19:26 [GIT PULL] Kselftest update for Linux 5.4-rc1 Shuah Khan
2019-09-20 16:17 ` Linus Torvalds [this message]
2019-09-20 16:26 ` Randy Dunlap
[not found] ` <CAKRRn-edxk9Du70A27V=d3Na73fh=fVvGEVsQRGROrQm05YRrA@mail.gmail.com>
2019-09-20 16:35 ` Brendan Higgins
2019-09-20 16:51 ` Linus Torvalds
2019-09-20 18:03 ` Brendan Higgins
2019-09-20 18:14 ` Linus Torvalds
2019-09-20 18:16 ` Brendan Higgins
2019-09-20 18:06 ` Shuah Khan
2019-09-22 11:25 ` Ingo Molnar
2019-09-22 11:52 ` Greg KH
2019-09-23 14:44 ` Shuah Khan
2019-09-23 19:43 ` Ingo Molnar
2019-09-23 19:52 ` Randy Dunlap
2019-09-23 20:29 ` Shuah Khan
2019-09-23 20:53 ` Ingo Molnar
2019-09-23 21:11 ` Shuah Khan
2019-09-23 20:08 ` [RFC, Tree] De-clutter the top level directory, move ipc/ => kernel/ipc/, samples/ => Documentation/samples/ and sound/ => drivers/sound/ Ingo Molnar
2019-09-24 11:31 ` [Tree, v2] " Ingo Molnar
2019-09-24 15:28 ` Eric W. Biederman
2019-09-24 18:41 ` Ingo Molnar
2019-09-25 23:00 ` Eric W. Biederman
2019-09-23 23:54 ` [GIT PULL] Kselftest update for Linux 5.4-rc1 Tim.Bird
2019-09-24 8:07 ` Ingo Molnar
2019-09-26 12:52 ` David Sterba
2019-09-27 13:52 ` Pavel Machek
2019-10-03 9:08 ` Masahiro Yamada
2019-09-22 12:29 Alexey Dobriyan
2019-09-23 22:40 Shuah Khan
2019-09-26 20:10 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgs+UoZWfHGENWSVBd57Z-Vp0Nqe68R6wkDb5zF+cfvDg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).