linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: soc@kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	arm-soc <arm@kernel.org>
Subject: Re: [GIT PULL 4/6] ARM: SoC defconfig updates for 5.1
Date: Wed, 6 Mar 2019 10:15:17 -0800	[thread overview]
Message-ID: <CAHk-=wgzU7hcH+6oabXn-WDtCxvJhmG1Wopx0KLFo-o8ySPbHw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1k3y0ZHLxGNBoynF+tpej9PVQUT7PgP1RLCuXWonKmHg@mail.gmail.com>

Another small side note on these pull requests:

On Wed, Mar 6, 2019 at 7:35 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
>  arch/arm/configs/lpc32xx_defconfig    | 65
> +++++++++++++++++++++++++++++++----------------------------------

You have a lot of these kinds of line-wrapped diffstat lines.

The reason is *probably* that you've just cut-and-pasted from your
(very wide) terminal where you ran your scripts into the email.

Becaue if you run "git diff --stat" normally in a germinal, it will
take the terminal width into account.

If you run it in a script to a file or pipe, it will default width of
80 columns.

You could make your scripts just do "--stat=80" to do that, but you
might also consider using "xsel" to avoid the cutting-and-selecting
part, and just do

    my-release-script | xsel

to select the output of the script, and then paste it with your mouse...

This is not a big deal, but it does make those diffstats ugly, and I
_suspect_ it's because you didn't realize what is going on.

             Linus

  reply	other threads:[~2019-03-06 18:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 15:25 [GIT PULL 0/6] ARM: SoC changes for 5.1 Arnd Bergmann
2019-03-06 15:33 ` [GIT PULL 2/6] ARM: SoC device tree updates " Arnd Bergmann
2019-03-06 18:30   ` pr-tracker-bot
2019-03-06 15:34 ` [GIT PULL 3/6] ARM: SoC driver " Arnd Bergmann
2019-03-06 18:09   ` Linus Torvalds
2019-03-06 18:15     ` Russell King - ARM Linux admin
2019-03-06 18:28       ` Linus Torvalds
2019-03-06 18:30   ` pr-tracker-bot
2019-03-06 15:35 ` [GIT PULL 4/6] ARM: SoC defconfig " Arnd Bergmann
2019-03-06 18:15   ` Linus Torvalds [this message]
2019-03-06 19:49     ` Arnd Bergmann
2019-03-06 18:30   ` pr-tracker-bot
2019-03-06 15:36 ` [GIT PULL 5/6] ARM: New SoC family support " Arnd Bergmann
2019-03-06 18:30   ` pr-tracker-bot
2019-03-06 15:38 ` [GIT PULL 6/6] ARM: SoC late updates " Arnd Bergmann
2019-03-06 18:30   ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgzU7hcH+6oabXn-WDtCxvJhmG1Wopx0KLFo-o8ySPbHw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).