From: Linus Torvalds <torvalds@linux-foundation.org>
To: Borislav Petkov <bp@suse.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/cpu for v5.17
Date: Mon, 10 Jan 2022 10:18:06 -0800 [thread overview]
Message-ID: <CAHk-=wh+UbGrgH4CzKSoTYGPidyv5isiLMxJKAqnV3NFTiRdaQ@mail.gmail.com> (raw)
In-Reply-To: <YdwVl0H54fmUIux0@zn.tnic>
On Mon, Jan 10, 2022 at 3:16 AM Borislav Petkov <bp@suse.de> wrote:
>
> - Avoid writing MSR_CSTAR on Intel due to TDX guests raising a #VE trap
This is all fine, but my reaction to this is that I would have
expected it to be either a wrmsrl_safe(), or using an actual CPU
feature check.
Checking for a particular vendor seems a bit hacky. We generally try
to avoid things like that, don't we?
Not a big deal, I just thought I'd mention it since I reacted to it.
And we don't seem to have those vendor checks in any of the other code
that uses MSR_CSTAR (just grepping for that and seeing it mentioned in
kvm code etc)
Linus
next prev parent reply other threads:[~2022-01-10 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 11:16 [GIT PULL] x86/cpu for v5.17 Borislav Petkov
2022-01-10 18:18 ` Linus Torvalds [this message]
2022-01-10 18:35 ` Borislav Petkov
2022-01-10 19:32 ` Linus Torvalds
2022-01-10 20:10 ` Dave Hansen
2022-01-10 20:15 ` Linus Torvalds
2022-01-11 22:48 ` Sean Christopherson
2022-01-10 18:27 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh+UbGrgH4CzKSoTYGPidyv5isiLMxJKAqnV3NFTiRdaQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).