From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>,
Slavomir Kaslev <kaslevs@vmware.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes
Date: Mon, 4 Mar 2019 16:09:22 -0800 [thread overview]
Message-ID: <CAHk-=wh0ikMcREn-RLh-7TEeL28wj1-bHNTRsqpW_7dPuO7cAA@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wipy3J4r-dLim3QvNA2jVPi2uPCi=rTDiMYikBi5OiKnQ@mail.gmail.com>
On Mon, Mar 4, 2019 at 4:04 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Of course, if it turns out that this breaks something that assumes
> that splice blocks purely based on the SPLICE_F_NONBLOCK flag, we'll
> have to revert it. Looking at the history of splice, it does look like
> it has always ignored O_NONBLOCK.
Note that the "arguably buggy" argument is not an actual real argument
in the presence of regressions. It's more a "I wish reality wasn't
that way" argument, but it doesn't actually _change_ reality.
Of course, in the case of sendfile() (which is where that comment is),
I don't think we ever really even tested it either way.
Linus
next prev parent reply other threads:[~2019-03-05 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 15:45 [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes Slavomir Kaslev
2019-02-13 14:44 ` Steven Rostedt
2019-02-19 17:12 ` Steven Rostedt
2019-03-04 15:58 ` Steven Rostedt
2019-03-05 0:04 ` Linus Torvalds
2019-03-05 0:09 ` Linus Torvalds [this message]
2019-03-05 1:54 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh0ikMcREn-RLh-7TEeL28wj1-bHNTRsqpW_7dPuO7cAA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=kaslevs@vmware.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).