From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: Jan Kara <jack@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Marty Mcfadden <mcfadden8@llnl.gov>,
"Maya B . Gokhale" <gokhale2@llnl.gov>,
Jann Horn <jannh@google.com>, Christoph Hellwig <hch@lst.de>,
Oleg Nesterov <oleg@redhat.com>,
Kirill Shutemov <kirill@shutemov.name>
Subject: Re: [PATCH v3] mm/gup: Allow real explicit breaking of COW
Date: Fri, 21 Aug 2020 12:42:56 -0700 [thread overview]
Message-ID: <CAHk-=wh0syDtNzt9jGyHRV0r1pVX5gkdJWdenwmvy=dq0AL5mA@mail.gmail.com> (raw)
In-Reply-To: <20200821193100.GA38249@xz-x1>
On Fri, Aug 21, 2020 at 12:31 PM Peter Xu <peterx@redhat.com> wrote:
>
> However, do we really want to revert the whole logic of
> 52d1e606ee73? Asking because it still seems to be an improvement to me (after
> all we'll need to look after KSM pages here). So it seems still good to keep.
Does anybody have numbers for it?
I'd rather simplify and get rid of the locking that has been
problematic, and then re-introduce limited cases with actual numbers.
Right now that commit has no real argument for it except for "do what
we do for swap cache". And since we're getting rid of the swap cache
special case, I'd say that commit 52d1e606ee73 argues for getting rid
of the KSM special case too.
Honestly, I'd expect that if KSM is effective, it's for pages that
really *are* shared. If you get a lot of "write fault on the last
copy" and that ends up being a problem, I think that says more about
the KSM issue than it says about the write fault..
Linus
prev parent reply other threads:[~2020-08-21 19:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 18:39 [PATCH v3] mm/gup: Allow real explicit breaking of COW Peter Xu
2020-08-11 19:07 ` Jann Horn
2020-08-11 20:02 ` Peter Xu
2020-08-11 20:22 ` Jann Horn
2020-08-11 21:23 ` Peter Xu
2020-08-11 19:24 ` Linus Torvalds
2020-08-11 20:06 ` Linus Torvalds
2020-08-11 20:46 ` Linus Torvalds
2020-08-11 21:42 ` Peter Xu
2020-08-11 23:10 ` Linus Torvalds
2020-08-20 21:54 ` Peter Xu
2020-08-20 22:01 ` Linus Torvalds
2020-08-21 10:13 ` Jan Kara
2020-08-21 12:27 ` Linus Torvalds
2020-08-21 15:47 ` Jan Kara
2020-08-21 17:00 ` Linus Torvalds
2020-08-21 18:08 ` Peter Xu
2020-08-21 18:23 ` Linus Torvalds
2020-08-21 19:05 ` Linus Torvalds
2020-08-21 19:06 ` Linus Torvalds
2020-08-21 19:31 ` Peter Xu
2020-08-21 19:42 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh0syDtNzt9jGyHRV0r1pVX5gkdJWdenwmvy=dq0AL5mA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gokhale2@llnl.gov \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcfadden8@llnl.gov \
--cc=oleg@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).