linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>
Subject: Re: [GIT PULL] Misc driver fix for 5.15-rc1
Date: Sun, 12 Sep 2021 12:03:35 -0700	[thread overview]
Message-ID: <CAHk-=wh7FYyewcJkozsjA95yj0AYvmpMDoZd0RxQ3ZbMMdXUdQ@mail.gmail.com> (raw)
In-Reply-To: <YT4IvKLQHm9mfpR+@kroah.com>

On Sun, Sep 12, 2021 at 7:03 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> It resolves a build issue that many people were hitting with your
> current tree [...]

I was like "Oh, serious build problems"..

But as far as I can tell, the "build issue" is that a couple of files
get recompiled every time you add a commit. Ok, that added possibly a
few seconds to the build.

So fixing that is good, but why is that lkdtm driver insisting on
writing the release and machine information AT ALL?

IOW, the fix seems kind of silly. The kernel release information
should just have been removed entirely, because the kernel prints that
out as the very first thing anyway, so 'dmesg' will have something
like

    Linux version 5.14.0-11181-gd8e988b62f94 (torvalds@ryzen) (clang
version 12.0.1 ...

at the very top.

So I think that whole 'lkdtm_kernel_info' thing is all kinds of pointless.

Could we please just stop pointlessly printing out kernel version data
that  is already available other ways? Just do 'dmesg', or 'uname -r'
or whatever instead of insisting on printing out redundant
information?

           Linus

  reply	other threads:[~2021-09-12 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 14:03 [GIT PULL] Misc driver fix for 5.15-rc1 Greg KH
2021-09-12 19:03 ` Linus Torvalds [this message]
2021-09-12 19:17   ` Kees Cook
2021-09-12 19:22     ` Linus Torvalds
2021-09-12 19:44       ` Kees Cook
2021-09-12 19:55         ` Linus Torvalds
2021-09-12 22:26           ` Kees Cook
2021-09-12 19:16 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wh7FYyewcJkozsjA95yj0AYvmpMDoZd0RxQ3ZbMMdXUdQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).