From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Maxime Ripard <maxime@cerno.tech>, Emma Anholt <emma@anholt.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Philipp Zabel <p.zabel@pengutronix.de>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Regression with mainline kernel on rpi4
Date: Wed, 22 Sep 2021 13:25:21 -0700 [thread overview]
Message-ID: <CAHk-=whASMriPYRdH8kxC_UwObBtwHbPvf7rb58sUEZZyaFxJg@mail.gmail.com> (raw)
In-Reply-To: <CADVatmPDeSxeY3GTZyC6+G0N76su0E6Y3LF_h6BOcBf5QAtjvg@mail.gmail.com>
On Wed, Sep 22, 2021 at 1:19 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> I added some debugs to print the addresses, and I am getting:
> [ 38.813809] sudip crtc 0000000000000000
>
> This is from struct drm_crtc *crtc = connector->state->crtc;
Yeah, that was my personal suspicion, because while the line number
implied "crtc->state" being NULL, the drm data structure documentation
and other drivers both imply that "crtc" was the more likely one.
I suspect a simple
if (!crtc)
return;
in vc4_hdmi_set_n_cts() is at least part of the fix for this all, but
I didn't check if there is possibly something else that needs to be
done too.
Linus
next prev parent reply other threads:[~2021-09-22 20:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:08 Regression with mainline kernel on rpi4 Sudip Mukherjee
2021-09-03 16:03 ` Maxime Ripard
2021-09-03 20:09 ` Sudip Mukherjee
2021-09-04 9:10 ` Maxime Ripard
2021-09-04 9:40 ` Sudip Mukherjee
2021-09-20 14:47 ` Maxime Ripard
2021-09-20 15:43 ` Maxime Ripard
2021-09-20 15:53 ` Maxime Ripard
2021-09-20 16:35 ` Sudip Mukherjee
2021-09-20 17:10 ` Maxime Ripard
2021-09-20 17:21 ` Sudip Mukherjee
2021-09-22 9:57 ` Maxime Ripard
2021-09-22 10:10 ` Sudip Mukherjee
2021-09-22 11:28 ` Maxime Ripard
2021-09-22 17:18 ` Sudip Mukherjee
2021-09-22 15:22 ` Linus Torvalds
2021-09-22 17:02 ` Sudip Mukherjee
2021-09-22 18:23 ` Linus Torvalds
2021-09-22 20:19 ` Sudip Mukherjee
2021-09-22 20:25 ` Linus Torvalds [this message]
2021-09-24 13:30 ` Maxime Ripard
2021-09-24 22:50 ` Daniel Vetter
2021-09-28 8:34 ` Maxime Ripard
2021-09-30 9:19 ` Daniel Vetter
2021-10-13 15:01 ` Maxime Ripard
2021-10-14 13:15 ` Daniel Vetter
2021-10-25 14:15 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whASMriPYRdH8kxC_UwObBtwHbPvf7rb58sUEZZyaFxJg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=p.zabel@pengutronix.de \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).