From: Linus Torvalds <torvalds@linux-foundation.org>
To: kernel test robot <rong.a.chen@intel.com>
Cc: Jann Horn <jannh@google.com>, Christoph Hellwig <hch@lst.de>,
Oleg Nesterov <oleg@redhat.com>,
Kirill Shutemov <kirill@shutemov.name>, Jan Kara <jack@suse.cz>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org
Subject: Re: [gup] 17839856fd: stress-ng.vm-splice.ops_per_sec 2158.6% improvement
Date: Thu, 11 Jun 2020 13:24:09 -0700 [thread overview]
Message-ID: <CAHk-=whCjhBgJv0z6JoOKMyfnBp0WhH6oa=ayuRRLtgJxOkd5Q@mail.gmail.com> (raw)
In-Reply-To: <20200611040453.GK12456@shao2-debian>
On Wed, Jun 10, 2020 at 9:05 PM kernel test robot <rong.a.chen@intel.com> wrote:
>
> FYI, we noticed a 2158.6% improvement of stress-ng.vm-splice.ops_per_sec due to commit:
>
> commit: 17839856fd588f4ab6b789f482ed3ffd7c403e1f ("gup: document and work around "COW can break either way" issue")
Well, that is amusing, and seeing improvements is always nice, but
somehow I think the test is broken.
I can't see why you'd ever see an improvement from that commit, and if
you do see one, not one by a factor of 20x.
> In addition to that, the commit also has significant impact on the following tests:
>
> | testcase: change | stress-ng: stress-ng.vm-splice.ops_per_sec 372.8% improvement |
> | testcase: change | stress-ng: stress-ng.vm-splice.ops_per_sec 2052.7% improvement |
Ok, so it's affecting other runs of the same test, and the smaller
("only" 378%) improvement seems to be just from using fewer threads.
So maybe forcing the COW ends up avoiding some very specific cache
thrashing case.
> To reproduce:
>
> git clone https://github.com/intel/lkp-tests.git
> cd lkp-tests
> bin/lkp install job.yaml # job file is attached in this email
> bin/lkp run job.yaml
Is there some place where you'd actually _see_ what
"stress-ng.vm-splice.ops_per_sec" actually means and does?
Yeah, I can go and find the actual stress-ng git repo, and take a
look. I kind of did. But the step from your "to reproduce" to actually
figuring out what is going on is pretty big.
It would be nice to know what it actually does - do you have a
database of descriptions for the different tests and how to run them
individually or anything like that?
IOW, rather than the above "just run all fo the lkp scripts",
something like how to run the actual individual test would be good.
IOW how do those yaml files translate into _actually_ running the
'stress-ng' program?
Linus
next prev parent reply other threads:[~2020-06-11 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 4:04 [gup] 17839856fd: stress-ng.vm-splice.ops_per_sec 2158.6% improvement kernel test robot
2020-06-11 20:24 ` Linus Torvalds [this message]
2020-06-12 0:07 ` [LKP] " Philip Li
2020-06-15 6:58 ` Feng Tang
2020-06-15 7:32 ` Jann Horn
2020-06-15 8:33 ` [LKP] " Feng Tang
2020-06-15 19:09 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whCjhBgJv0z6JoOKMyfnBp0WhH6oa=ayuRRLtgJxOkd5Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=oleg@redhat.com \
--cc=rong.a.chen@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).