From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92760C07E95 for ; Sun, 4 Jul 2021 22:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 796866128D for ; Sun, 4 Jul 2021 22:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbhGDWrQ (ORCPT ); Sun, 4 Jul 2021 18:47:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhGDWrN (ORCPT ); Sun, 4 Jul 2021 18:47:13 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50686C061574 for ; Sun, 4 Jul 2021 15:44:37 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id f30so29041055lfj.1 for ; Sun, 04 Jul 2021 15:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EGqC5BUSu2ehzvKSXDbnDhJ8xnzNi8pYNcVJXKy8JEU=; b=D649w4q4OxkBSA1lvEBQVo/GHPy3qeR5KImijL8NQR+L0JKOAdLHriM8xcL9de098Q sRtPfGnSydxT77lUSdmQB+Pz9ADMcoT/ScQKZo9UH7N2VJ/DIVJlvsqtvKSMU181vctn kofK7f3zkUHvFWd+Keakq7yRCz+HKhWao3HH4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EGqC5BUSu2ehzvKSXDbnDhJ8xnzNi8pYNcVJXKy8JEU=; b=KreVom8L8egxNwnZwAK69QnX9W0sEmtrSnhPaeOA0ljGvGrJu+Q9leF2wQlHdf/dPr eDBiJ0+KH/bcVN8krHueQb9k2xjSsYk9PtloXhWwCGdckJi3FPrQR61ZHHo9H9k8KlWi 4frer9sMOchhGyiY+XTh3mlB6c8pcorEbviqmsNL+oBjCk23llMKj/yozd8QHAhe5xTM kzqQnmHi0KMgXn4no8Uj1M3lvyNg4UwhJg7Wc3u40REeLXhbzqzd6IXAlkmD6cCvFdK0 l2daZpqQwVzxwJ3e26qCbaN285+jYClwC+nQ8nuwQ8FYWxHHDz9SKTkUFzBIHSWDZAJQ c1Ew== X-Gm-Message-State: AOAM530dtZ94BVroKTkEjXwMwdFyPqBB7gX1LIyHcksPL9SY0GJ4D9tJ wgGI1KwevJWbilg+7266r7X18Fmyvdc8lkJ0 X-Google-Smtp-Source: ABdhPJy8+3StvQFntTqNpD27PXTpcTspu0ZYiPG6gLsn7YR9xUO6engS19OMfxhaQQxBsX1uVCttiA== X-Received: by 2002:ac2:5396:: with SMTP id g22mr8055998lfh.641.1625438674905; Sun, 04 Jul 2021 15:44:34 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id d26sm427141ljo.76.2021.07.04.15.44.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 15:44:34 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id s18so255947ljg.7 for ; Sun, 04 Jul 2021 15:44:33 -0700 (PDT) X-Received: by 2002:a05:651c:32e:: with SMTP id b14mr8539760ljp.251.1625438673695; Sun, 04 Jul 2021 15:44:33 -0700 (PDT) MIME-Version: 1.0 References: <20210704172948.GA1730187@roeck-us.net> <676ae33e-4e46-870f-5e22-462fc97959ed@roeck-us.net> <19689998-9dfe-76a8-30d4-162648e04480@roeck-us.net> <03a15dbd-bdb9-1c72-a5cd-2e6a6d49af2b@roeck-us.net> In-Reply-To: <03a15dbd-bdb9-1c72-a5cd-2e6a6d49af2b@roeck-us.net> From: Linus Torvalds Date: Sun, 4 Jul 2021 15:44:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] iov_iter: separate direction from flavour To: Guenter Roeck Cc: Christoph Hellwig , Al Viro , linux-fsdevel , Linux Kernel Mailing List , David Sterba , Miklos Szeredi , Anton Altaparmakov , David Howells , Matthew Wilcox , Pavel Begunkov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 4, 2021 at 2:47 PM Guenter Roeck wrote: > > How about the following ? > > WARN_ON_ONCE(IS_ENABLED(CONFIG_MMU) && uaccess_kernel()); Nope, that doesn't work either, because there are no-MMU setups that don't make the same mistake no-mmu arm and m68k do. Example: xtensa. But afaik also generic-asm/uaccess.h unless the architecture overrides something. So this literally seems like just an arm/m68k bug. Linus