From: Linus Torvalds <torvalds@linux-foundation.org>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [GIT PULL] arm64 fixes for -rc5
Date: Fri, 6 Aug 2021 11:40:33 -0700 [thread overview]
Message-ID: <CAHk-=whNiAtCUqeCAcq+GKjmOXFfLCYA84TpeeL2085c+BdmQQ@mail.gmail.com> (raw)
In-Reply-To: <20210806135331.GA2951@willie-the-truck>
On Fri, Aug 6, 2021 at 6:53 AM Will Deacon <will@kernel.org> wrote:
>
> Please pull these arm64 fixes for -rc5. It's all pretty minor but the
> main fix is sorting out how we deal with return values from 32-bit system
> calls as audit expects error codes to be sign-extended to 64 bits
I've pulled this, but that change looks _really_ odd.
First you seem to intentionally *zero-extend* the error value when you
actually set it in pt_regs, and then you sign-extend them when reading
them.
So the rules seem entirely arbitrary: oen place says "upper 32 bits
need to be clear" and another place says "upper 32 bits need to be
sign-extended".
Why this insanity? Why not make the rule be that the upper 32 bits are
always just sign-extended?
Linus
next prev parent reply other threads:[~2021-08-06 18:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 13:53 [GIT PULL] arm64 fixes for -rc5 Will Deacon
2021-08-06 18:40 ` Linus Torvalds [this message]
2021-08-09 10:52 ` Will Deacon
2021-08-06 18:48 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2024-02-16 11:58 Will Deacon
2024-02-16 18:52 ` pr-tracker-bot
2023-10-06 7:56 Will Deacon
2023-10-06 15:15 ` pr-tracker-bot
2023-07-21 11:44 Will Deacon
2023-07-21 11:45 ` Will Deacon
2023-07-21 17:28 ` pr-tracker-bot
2022-09-11 11:37 Will Deacon
2022-09-11 19:36 ` pr-tracker-bot
2021-03-25 14:54 [GIT PULL] arm64: Fixes " Will Deacon
2021-03-25 19:13 ` pr-tracker-bot
2020-07-10 14:39 [GIT PULL] arm64 fixes " Will Deacon
2020-07-10 16:55 ` pr-tracker-bot
2020-03-06 15:12 Will Deacon
2020-03-06 20:55 ` pr-tracker-bot
2019-06-14 15:02 [GIT PULL] arm64: " Will Deacon
2019-06-14 16:20 ` pr-tracker-bot
2019-04-12 16:05 [GIT PULL] arm64 " Will Deacon
2019-04-13 17:40 ` pr-tracker-bot
2019-02-01 17:51 [GIT PULL] arm64: " Will Deacon
2019-02-02 1:00 ` pr-tracker-bot
2018-05-11 17:30 Will Deacon
2017-03-31 17:15 Will Deacon
2016-06-24 11:41 Will Deacon
2016-02-19 16:29 Will Deacon
2015-10-07 14:20 Will Deacon
2015-01-16 17:16 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whNiAtCUqeCAcq+GKjmOXFfLCYA84TpeeL2085c+BdmQQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).