linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Peter Rosin <peda@axentia.se>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mux: remove the Kconfig question for the subsystem
Date: Wed, 7 Dec 2022 11:16:52 -0800	[thread overview]
Message-ID: <CAHk-=whWKBKmoq-BOCgFGfZQ45vPP2ujb-wAG8q2PCvjngz3yg@mail.gmail.com> (raw)
In-Reply-To: <f5fe43c0-907e-e5b0-7642-6748f3b1b31c@infradead.org>

On Wed, Dec 7, 2022 at 11:03 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 12/7/22 10:57, Arnd Bergmann wrote:
> >
> > They cannot, that is the entire point of hiding the subsystem
> > when it is not used.
>
> OK, if you say so. That doesn't make any sense to me, but whatever,
> I'll drop it.

The config phase of the kernel is one of the more annoying parts (the
rest is pretty much "make" and "make install"), and we should strive
to make it as simple and obvious as possible.

One big thing for that is to *not* ask questions that make no sense.

We already hide a number of them, either by disallowing them ("this
driver only makes sense on this architecture" kinds of things) or by
always forcing them on  ("if you're building for a PC, you're getting
the keyboard driver whether you want it or not").

And in many cases, we don't have questions at all, but enable code
based on automatic selection (ie "you wanted ACPI support, so we'll
enable CRC32 support because the ACPI code needs it").

I don't understand *why* you'd ever want more nonsensical questions?

Why would you ever want to ask a human "do you want this code that is
never used"?

That, to me, is actively a horrible thing to do. It only makes the
Kconfig worse. Don't do it.

         Linus

      parent reply	other threads:[~2022-12-07 19:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+55aFyJkpSa6rwZ-5xTihfGiNC_T0oL6txrodYBEo2-0O=p7g@mail.gmail.com>
2017-07-04  8:22 ` [PATCH v2] mux: remove the Kconfig question for the subsystem Peter Rosin
2017-07-04  9:01   ` Greg KH
2017-07-04 21:03   ` Linus Torvalds
2022-12-06 22:20   ` Randy Dunlap
2022-12-07  8:41     ` Arnd Bergmann
2022-12-07 17:19       ` Randy Dunlap
2022-12-07 18:57         ` Arnd Bergmann
2022-12-07 19:03           ` Randy Dunlap
2022-12-07 19:15             ` Randy Dunlap
2022-12-07 19:23               ` Linus Torvalds
2022-12-07 19:16             ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=whWKBKmoq-BOCgFGfZQ45vPP2ujb-wAG8q2PCvjngz3yg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).