From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30805C49ED7 for ; Tue, 17 Sep 2019 01:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03977206A1 for ; Tue, 17 Sep 2019 01:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568684518; bh=qyph07UWpAex17FgoCL1r5b+7tyl4ETGGhdXOzgUefU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=dbwQSOjAd55v74/BvF3jPv2DrhZ/iLfN3dXbuWZuAAKiu/6MqRJPg3mDvQmUC5lTi N2p0n5x1t8oOpR3FQiqNckLz2rir/KxjEzbYtQkctRlh/+ihxx12UC5iYYwZsfLvUx HamlrVLQUD26ZKfDXRQXsEM9QFWZJ2fDt2rc9vRc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391744AbfIQBl5 (ORCPT ); Mon, 16 Sep 2019 21:41:57 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45457 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728211AbfIQBl4 (ORCPT ); Mon, 16 Sep 2019 21:41:56 -0400 Received: by mail-lj1-f193.google.com with SMTP id q64so1714466ljb.12 for ; Mon, 16 Sep 2019 18:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eFonvhfNYcxKepSfnQcuhKAjMEuQmhnrqu5ZWiTPe6o=; b=Bmy2g+SI64cuFudCSab745GhMwBUH8vFBHoCEPyte/aVPJTeqvf0Ub3G6d17emIl2S cXEEoOWnhpdJi6yi8YT0lVGj2snzwX9DRJYCmT2Fi2PkFCGtXGxs2cGseskytXSyw5ue jAlwgncWpCtsxiLRT6WPIAxhjk0PtHEWVcWT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eFonvhfNYcxKepSfnQcuhKAjMEuQmhnrqu5ZWiTPe6o=; b=e3M332kNW+jopYoRpChd4a/dBU22Vwy8dAVD8mL0zUp0ugmxCspjLGZFQwyzm8lT53 w8OJJcRa6Bo6V+bc8FMIyZY6ppGEYqhfpRa7f4BwfKfVJX1ZKERTI018BbtwQiVDwXIc lPe2X0vLm8YGzjDleI3Ji3/9AidtUaF67q0TH4veH56xfs5UyYZ3mslIdcQTOd0oeel7 YMq/67LEyUj7JkFumWPtxdJhkSXUyJyQi5UulRIbPmk/jbdvdHrpJRuszTfwfoBd8agO ZyeqAa8iLj9BD5LI39hZbIP/E+aPZod0kygmFBPRBCjENx0kOCS1gNSVOMRTpV62+glu qVkA== X-Gm-Message-State: APjAAAXedq3o9m5QPmsZI/+0aYSlSPNi5k4YrWphVDeK/CvfPEoBkLOU lg4MM9/DHbXe9oY4sb3QivUfzou8Onw= X-Google-Smtp-Source: APXvYqyW5AcUk3GXTEgL0/ZryoYY1aHqwDxLILigR+H4Y1KGQqvDJ+Qx5DNGdcapPciuXmLKgyrZPw== X-Received: by 2002:a2e:9b4f:: with SMTP id o15mr396461ljj.142.1568684514367; Mon, 16 Sep 2019 18:41:54 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id 25sm111157lje.58.2019.09.16.18.41.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2019 18:41:53 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id w67so1492115lff.4 for ; Mon, 16 Sep 2019 18:41:52 -0700 (PDT) X-Received: by 2002:ac2:5a4c:: with SMTP id r12mr577900lfn.52.1568684512695; Mon, 16 Sep 2019 18:41:52 -0700 (PDT) MIME-Version: 1.0 References: <20190916042952.GB23719@1wt.eu> <20190916061252.GA24002@1wt.eu> <20190916172117.GB15263@mit.edu> <20190916230217.vmgvsm6o2o4uq5j7@srcf.ucam.org> <20190916231103.bic65ab4ifv7vhio@srcf.ucam.org> <20190916232922.GA7880@darwi-home-pc> In-Reply-To: From: Linus Torvalds Date: Mon, 16 Sep 2019 18:41:36 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Linux 5.3-rc8 To: Matthew Garrett Cc: "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Vito Caputo , Lennart Poettering , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , "Alexander E. Patrakov" , zhangjs , linux-ext4@vger.kernel.org, lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 6:24 PM Matthew Garrett wrote: > > Exactly the scenario where you want getrandom() to block, yes. It *would* block. Just not forever. And btw, the whole "generate key at boot when nothing else is going on" is already broken, so presumably nobody actually does it. See why I'm saying "hypothetical"? You're doing it again. > >Then you have to ignore the big warning too. > > The big warning that's only printed in dmesg? Well, the patch actually made getrandom() return en error too, but you seem more interested in the hypotheticals than in arguing actualities. Linus