From: Linus Torvalds <torvalds@linux-foundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Maria Yu <quic_aiquny@quicinc.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Chester Lin <clin@suse.com>
Subject: Re: [GIT PULL] Pin control fixes for v6.7
Date: Wed, 29 Nov 2023 06:55:57 -0800 [thread overview]
Message-ID: <CAHk-=whk4oNQazgpzkujc2=ntVQMhU5ko7Canp2Uuq6CpyGzmA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdZtVNZFWSUgb4=gUE2mQRb=aT_3=zRv1U71Vsq0Mm34eg@mail.gmail.com>
On Wed, 29 Nov 2023 at 04:09, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> The most interesting patch is the list iterator fix in the core by Maria
> Yu, it took a while for me to realize what was going on there.
That commit message still doesn't explain what the problem was.
Why is p->state volatile there? It seems to be a serious locking bug
if p->state can randomly change there, and the READ_ONCE() looks like
a "this hides the problem" rather than an actual real fix.
Linus
next prev parent reply other threads:[~2023-11-29 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 12:09 [GIT PULL] Pin control fixes for v6.7 Linus Walleij
2023-11-29 14:55 ` Linus Torvalds [this message]
2023-11-29 15:08 ` Linus Walleij
2023-11-30 5:37 ` Aiqun(Maria) Yu
2023-12-01 8:10 ` Linus Walleij
2023-12-01 8:12 ` Linus Walleij
2023-12-01 10:06 ` Aiqun(Maria) Yu
2023-12-01 15:34 ` Aiqun(Maria) Yu
2023-11-29 15:47 ` pr-tracker-bot
2023-12-21 22:50 [GIT PULL] pin " Linus Walleij
2023-12-22 0:58 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whk4oNQazgpzkujc2=ntVQMhU5ko7Canp2Uuq6CpyGzmA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=clin@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).