Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro

From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ulrich Teichert <krypton@ulrich-teichert.org>
Cc: Michael Cree <mcree@orcon.net.nz>,
	Guenter Roeck <linux@roeck-us.net>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	alpha <linux-alpha@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-parisc <linux-parisc@vger.kernel.org>,
	Netdev <netdev@vger.kernel.org>,
	Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro
Date: Tue, 21 Sep 2021 14:39:06 -0700	[thread overview]
Message-ID: <CAHk-=whwreptD=WByMRNsv-gfqR3oUu4v33i5Swd2dyeLObyRw@mail.gmail.com> (raw)
In-Reply-To: <202109211913.18LJDnXp031134@valdese.nms.ulrich-teichert.org>

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

On Tue, Sep 21, 2021 at 12:14 PM Ulrich Teichert
<krypton@ulrich-teichert.org> wrote:
>
> I would try the SRM bootimage (make bootimage), but the build is broken:

The attached patch is too ugly for words, and there's no way I will
commit anything like this.

But it at least builds for and seems to successfully make an alpha
bootimage even when cross-compiling on x86-64.

So something to test, perhaps..

           Linus

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 2064 bytes --]

 arch/alpha/boot/stdio.c          |  1 +
 arch/alpha/boot/tools/objstrip.c | 19 +++++++++++++++----
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/arch/alpha/boot/stdio.c b/arch/alpha/boot/stdio.c
index 60f73ccd2e89..2b91b86aafde 100644
--- a/arch/alpha/boot/stdio.c
+++ b/arch/alpha/boot/stdio.c
@@ -247,6 +247,7 @@ int vsprintf(char *buf, const char *fmt, va_list args)
 
 		case 'X':
 			flags |= LARGE;
+			fallthrough;
 		case 'x':
 			base = 16;
 			break;
diff --git a/arch/alpha/boot/tools/objstrip.c b/arch/alpha/boot/tools/objstrip.c
index 08b430d25a31..1feb04af93b6 100644
--- a/arch/alpha/boot/tools/objstrip.c
+++ b/arch/alpha/boot/tools/objstrip.c
@@ -23,7 +23,6 @@
 #include <sys/stat.h>
 #include <sys/types.h>
 
-#include <linux/a.out.h>
 #include <linux/coff.h>
 #include <linux/param.h>
 #ifdef __ELF__
@@ -33,6 +32,11 @@
 # define elf_check_arch(x) ((x)->e_machine == EM_ALPHA)
 #endif
 
+/* Hack hack. We want the _alpha_ uapi/asm/a.out.h */
+#include "../../include/uapi/asm/a.out.h"
+#define _ASM_X86_A_OUT_H
+#include <linux/a.out.h>
+
 /* bootfile size must be multiple of BLOCK_SIZE: */
 #define BLOCK_SIZE	512
 
@@ -48,6 +52,11 @@ usage (void)
     exit(1);
 }
 
+static __always_inline size_t str_has_prefix(const char *str, const char *prefix)
+{
+	size_t len = strlen(prefix);
+	return strncmp(str, prefix, len) == 0 ? len : 0;
+}
 
 int
 main (int argc, char *argv[])
@@ -190,7 +199,7 @@ main (int argc, char *argv[])
 	if (verbose) {
 	    fprintf(stderr, "%s: extracting %#016lx-%#016lx (at %lx)\n",
 		    prog_name, (long) elf_phdr->p_vaddr,
-		    elf_phdr->p_vaddr + fil_size, offset);
+		(long) elf_phdr->p_vaddr + fil_size, offset);
 	}
     } else
 #endif
@@ -220,8 +229,10 @@ main (int argc, char *argv[])
 
 	if (verbose) {
 	    fprintf(stderr, "%s: extracting %#016lx-%#016lx (at %lx)\n",
-		    prog_name, aout->ah.text_start,
-		    aout->ah.text_start + fil_size, offset);
+		    prog_name,
+		    (long)aout->ah.text_start,
+		    (long)aout->ah.text_start + fil_size,
+		    offset);
 	}
     }
 
