From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF7EC4CECD for ; Mon, 27 Apr 2020 20:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2A702070B for ; Mon, 27 Apr 2020 20:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588020407; bh=S0JGqMXyfhwp4pwnB+rzqtWpJTu9aRY8xFng4Qs4J64=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=eI2tzVcdg4TMpxhQsZvyl1YckUpwQEgmFcGibuvdgH14awRx55wxbAZ37t1vqL7nH JaJoYPjUIptuCc9fUZ+a75ZOi9O5HU4EVHKv3P6ZUe73lmsVKg4Q5JytHqeoUGDSPP 4YIeMooZmtFUumLXhPSw37YBF2xcB16cGWB3FOOU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgD0Uqr (ORCPT ); Mon, 27 Apr 2020 16:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726233AbgD0Uqq (ORCPT ); Mon, 27 Apr 2020 16:46:46 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B3FC0610D5 for ; Mon, 27 Apr 2020 13:46:44 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id t11so15007306lfe.4 for ; Mon, 27 Apr 2020 13:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dWR2+QPOvDM4Hcpn5wbulNRTutKr2RiZhAYOOOoHLGE=; b=XXUouBL3HsVdD5w4SVkh5b5D8g9+OFHyEx+DyQoaqHU6zlLiC7Dv4gWIn8To8ExMgw NntG+tgahRdl4PgQkAptOglp72S4qq9gaTpBKYXOGyoVBKVhhZlHK+aoAtOs0FgfdNnG Q4eXzMDYFO1E9IXcsn+dcaRD4uEyvCywvcRfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dWR2+QPOvDM4Hcpn5wbulNRTutKr2RiZhAYOOOoHLGE=; b=McutMoyy8u7finb679WxfYPejebul/aUgMUtTSnIGtYBjHUlZHYqs2bdCnqLX2ChNB thDAaHLI2oVNIqufk0AkoFH9uVUlG6JCAOoEP3ai80pMb0hXZCtzm0lwVsa4bZh1hBJI QQ6YXc8f4Ovza5/7x61ZfNjNc7dAegEtNJFWDBGba8W9I+ljfWWvTcD7iFapM3aLtO49 977OIO7CaX4R4oRZ038OIPV2n+WMuSBHG5csWnuEahxQElv7m2+Xxpqg96unw2u+rAO/ RcphQUhsHnYtr+IoZhbt0Yk3cunMsUym7fJlu1wY+r4No1FhxXUmvaegO/czopEcXa5J Ph3g== X-Gm-Message-State: AGi0PuZU+WhymPPWg/WtA9T1gJaD6Loo1r5TxSpw4GKK4O/xYCSyDZ4I dAHBMUEv/bUYhGvqKKed2wHeioT88RY= X-Google-Smtp-Source: APiQypJhDfxcdP4Ub0wCcaMrGE1KL7Kre6rARAO1kTHkvlHXEm6ltjCwzseUWom4Xu+g2ySHuogURQ== X-Received: by 2002:ac2:4213:: with SMTP id y19mr15620705lfh.99.1588020402519; Mon, 27 Apr 2020 13:46:42 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id r9sm10176766ljh.36.2020.04.27.13.46.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 13:46:41 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id t11so15007240lfe.4 for ; Mon, 27 Apr 2020 13:46:41 -0700 (PDT) X-Received: by 2002:a19:240a:: with SMTP id k10mr16839809lfk.30.1588020401250; Mon, 27 Apr 2020 13:46:41 -0700 (PDT) MIME-Version: 1.0 References: <20200425133504.GA11354@nishad> <20200427155617.GY6749@magnolia> <20200427172959.GB3936841@kroah.com> <515362d10c06567f35f0d5b7c3f2e121769fb04b.camel@perches.com> <20200427174611.GA4035548@kroah.com> <791a97d5d4dfd11af533a0bbd6ae27d1a2d479ee.camel@perches.com> <20200427183629.GA20158@kroah.com> <16b209d0b0c8034db62f8d4d0a260a00f0aa5d5e.camel@perches.com> In-Reply-To: From: Linus Torvalds Date: Mon, 27 Apr 2020 13:46:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] xfs: Use the correct style for SPDX License Identifier To: Joe Perches Cc: Greg Kroah-Hartman , "Darrick J. Wong" , Kate Stewart , Nishad Kamdar , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Pengutronix Kernel Team , linux-xfs , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 1:39 PM Joe Perches wrote: > > > The fact is, there *is * a reason to avoid the pedantic "change to new > > version" - pointless churn. > > Have you *looked* at this proposed change? > > It just changes // SPDX comments to /* */ in .h files. That's not what I was reacting to - it was you arguing with Greg about how we use the legacy format. I really don't care at all about the comment character choices (either), but wanted to point out that as far as the kernel is concerned, the "deprecated" spdx keys simply arent' deprecated, they are just as valid. > Piecemeal changes aren't great. Piecemeal changes are fine, when the change doesn't have to be done AT ALL. There is simply no point in EVER changing "GPL-2.0" into "GPL-2.0-only" etc, unless the thing is then touched for some other reason (which it may never be). Scripted changes are not as useful as you think. They often cause unnecessary noise in other respects. I'm constantly seeing stupid pointless work due to irrelevant patches that then show up in "get_maintainer" output because they show up as changes to drivbers that nobody cares about. Or "git blame -C" things that I have to ignore and go past that history because the scripted change showed an (uninteresting) change. The fact is, pointless churn is BAD. It's a real expense. The whole "get it over with once" argument is simply completely wrong. There are real advantages to "don't touch stuff that doesn't actively need touching". Linus