From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E77A9C4338F for ; Sat, 14 Aug 2021 01:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9C1E600CC for ; Sat, 14 Aug 2021 01:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236257AbhHNBVt (ORCPT ); Fri, 13 Aug 2021 21:21:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236128AbhHNBVs (ORCPT ); Fri, 13 Aug 2021 21:21:48 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8B9FC061756 for ; Fri, 13 Aug 2021 18:21:20 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id i6so18006067edu.1 for ; Fri, 13 Aug 2021 18:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xExJpARMLMkrq8sMXVZNiU6Vj9o2jrh13qRTaWd9c2s=; b=Sqr8VKtXgD581Tr4kn0EKrE7Z4POJhc426hpxltKuo89M4OxOeAqlheILSJpT3dpYb q26BxI3Tvc6AA/uqWqN0TqwJYd9SWTrC6FI7jk168E6pkyeUJGRl1snaKAfr4Foeaya2 LoZc61X3CPgeQHcVM2mnCJvkbddQu0jakBCug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xExJpARMLMkrq8sMXVZNiU6Vj9o2jrh13qRTaWd9c2s=; b=ngT9ixhGHrXYZBPlvhXEaDWTPAOqyczW1mwLqQw3EbMQ9Iy5c6g4nPZ/w7xYd8VA2+ dwxQppOhSwWmTUTj0yy9e856i1ADd4JIwpdZTKzpQ/aV2IzY1bbhRnE+VLXH5f8y/vRb qrUGyu4+GT88jHxeGZEqe8vD9D/9suOdtdVT6nA45HtJ5lfvw4NAf7xMWC2Wkpe9VSz4 w2rz1yLkoYmFi1CNih1tiS2uVztlCb6PyPEDNhQcOzdsfp8jl1jeIZDlb5E9VJEEZMDn kz58+3gyGqjulSjoYYChhmB+Ryj8o+gPlC4vCVfTOxyKB2GPzNzRZApR3SlcSJTFBpsN W2YA== X-Gm-Message-State: AOAM532hcNX5Y2LmIyV1afi0Ry1lUhItnbntkI7Ve5suNvetAqXHYQzE VAdzITrQ14p/AsBDYshiEIqCfCAC9n8kIVrn70c= X-Google-Smtp-Source: ABdhPJw2m5lLMOxJ8AqIDGzCCM64o49xsjKX2tMDiYJbfWTltJhakhChuyRTmnr31RJFIHAjGvsrWg== X-Received: by 2002:a05:6402:1d19:: with SMTP id dg25mr6453731edb.153.1628904079429; Fri, 13 Aug 2021 18:21:19 -0700 (PDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id m25sm1577160edv.81.2021.08.13.18.21.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 18:21:19 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id w5so21478191ejq.2 for ; Fri, 13 Aug 2021 18:21:19 -0700 (PDT) X-Received: by 2002:a2e:81c2:: with SMTP id s2mr3500799ljg.48.1628902499779; Fri, 13 Aug 2021 17:54:59 -0700 (PDT) MIME-Version: 1.0 References: <20210812084348.6521-1-david@redhat.com> <87o8a2d0wf.fsf@disp2133> <60db2e61-6b00-44fa-b718-e4361fcc238c@www.fastmail.com> <87lf56bllc.fsf@disp2133> <87eeay8pqx.fsf@disp2133> <5b0d7c1e73ca43ef9ce6665fec6c4d7e@AcuMS.aculab.com> <87h7ft2j68.fsf@disp2133> In-Reply-To: From: Linus Torvalds Date: Fri, 13 Aug 2021 14:54:43 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/7] Remove in-tree usage of MAP_DENYWRITE To: Andy Lutomirski Cc: "Eric W. Biederman" , David Laight , David Hildenbrand , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Al Viro , Alexey Dobriyan , Steven Rostedt , "Peter Zijlstra (Intel)" , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Petr Mladek , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Kees Cook , Greg Ungerer , Geert Uytterhoeven , Mike Rapoport , Vlastimil Babka , Vincenzo Frascino , Chinwen Chang , Michel Lespinasse , Catalin Marinas , "Matthew Wilcox (Oracle)" , Huang Ying , Jann Horn , Feng Tang , Kevin Brodsky , Michael Ellerman , Shawn Anastasio , Steven Price , Nicholas Piggin , Christian Brauner , Jens Axboe , Gabriel Krisman Bertazi , Peter Xu , Suren Baghdasaryan , Shakeel Butt , Marco Elver , Daniel Jordan , Nicolas Viennot , Thomas Cedeno , Collin Fijalkovich , Michal Hocko , Miklos Szeredi , Chengguang Xu , =?UTF-8?Q?Christian_K=C3=B6nig?= , "linux-unionfs@vger.kernel.org" , Linux API , "the arch/x86 maintainers" , "" , Linux-MM , Florian Weimer , Michael Kerrisk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 2:49 PM Andy Lutomirski wrote: > > I=E2=80=99ll bite. How about we attack this in the opposite direction: r= emove the deny write mechanism entirely. I think that would be ok, except I can see somebody relying on it. It's broken, it's stupid, but we've done that ETXTBUSY for a _loong_ time. But you are right that we have removed parts of it over time (no more MAP_DENYWRITE, no more uselib()) so that what we have today is a fairly weak form of what we used to do. And nobody really complained when we weakened it, so maybe removing it entirely might be acceptable. Linus