linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] pipe: nonblocking rw for io_uring
Date: Mon, 24 Apr 2023 15:00:45 -0700	[thread overview]
Message-ID: <CAHk-=wiQ+S79vjAJf92TE8PqCie4xZPAhRgVchHnPesVHZPO0g@mail.gmail.com> (raw)
In-Reply-To: <ae8ee8f3-9960-1fd9-5471-433acacb6521@kernel.dk>

On Mon, Apr 24, 2023 at 2:55 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> I took another look at this, and the main issue is in fact splice
> confirming buffers. So I do think that we can make this work by simply
> having the non-block nature of it being passed down the ->confirm()
> callback as that's the one that'll be waiting for IO. If we have that,
> then we can disregard the pipe locking as we won't be holding it over
> IO.

Ok, that part looks fine to me.

The pipe_buf_confirm() part of the series I don't find problematic,
it's really conditional locking that I absolutely detest and has
always been a sign of problems elsewhere.

             Linus

  reply	other threads:[~2023-04-24 22:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:01 [GIT PULL] pipe: nonblocking rw for io_uring Christian Brauner
2023-04-24 21:05 ` Linus Torvalds
2023-04-24 21:22   ` Jens Axboe
2023-04-24 21:37     ` Linus Torvalds
2023-04-24 21:55       ` Jens Axboe
2023-04-24 22:00         ` Linus Torvalds [this message]
2023-04-24 22:05           ` Jens Axboe
2023-04-24 22:03         ` Jens Axboe
2023-04-24 21:58       ` Linus Torvalds
2023-04-24 22:07         ` Jens Axboe
2023-04-24 22:44           ` Jens Axboe
2023-04-25  3:16             ` Linus Torvalds
2023-04-25 13:46               ` Jens Axboe
2023-04-25 17:20               ` Linus Torvalds
2023-04-25 19:49                 ` Peter Zijlstra
2023-04-25 19:58                   ` Linus Torvalds
2023-04-25 20:10                     ` Jens Axboe
2023-04-25 20:29                     ` Linus Torvalds
     [not found]                     ` <978690c4-1d25-46e8-3375-45940ec1ea51@huaweicloud.com>
2023-05-08  8:39                       ` Peter Zijlstra
2023-05-08 10:16                         ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wiQ+S79vjAJf92TE8PqCie4xZPAhRgVchHnPesVHZPO0g@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).