From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E4EC00140 for ; Wed, 24 Aug 2022 18:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240484AbiHXSB1 (ORCPT ); Wed, 24 Aug 2022 14:01:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240753AbiHXSAy (ORCPT ); Wed, 24 Aug 2022 14:00:54 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A564112A92 for ; Wed, 24 Aug 2022 11:00:05 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id w19so35045099ejc.7 for ; Wed, 24 Aug 2022 11:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=ZH0AW3c9ztNqQzucg5KecEsPcM7OXPYg9d2t9+QVkjo=; b=hwRf6JyOT1Jyp0yqMsQEH6rdf0/piRq37jqkfAP9b+yj4UgKieh1p5lJ1PeSPPku84 Q3fgiavUUAOWFzbMHBjemM2EeNkp+0hFoRZsEJ/w8iL0FZCQspTvI5uiJGUuSao7RTjr OD0dVfYQ3C2R84vUtaqXCpY+azqvbS7HdWLIE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=ZH0AW3c9ztNqQzucg5KecEsPcM7OXPYg9d2t9+QVkjo=; b=RiUZUbeSp1ruiJWbTYX3/d3CEmTgCTw5suV1B61LPKZ/h6vrqa78ZpKQ9EACY/e5e6 b0UJQKqbHPLmxsFJBZTaNe3N0sJWVpJrRoIgZKVOFNOeBfHU1IcqJuxv2sqbKysBqXNe dUZgp7awbVrSnNYsrO/RW58TPxQjr4fKyTBv9V393YdbBKGvwJqgGBm38jHDcCwIf71R h6JIcxtO+JhMgGkz0zIkNM91Xfk43oUttiG47dKJmq+G3Uba1qWLINKZWQfazPl7++2h 66Jm89sx4G3Zmw+cVycwM13BAYzwIpb+IU0B/sMqDKfaifyTsc5xcAI8PNWr/Y/nJ2Pt uTGw== X-Gm-Message-State: ACgBeo0f2trsaZVuXTnsjx0S6beHTvugLS+CVrzGfUgNY4TwfJFTNcn6 lkjA4sl6JSVV7hMh4zPAR3UfgRS/qBb+vuGH X-Google-Smtp-Source: AA6agR5ENRR7eYtG+We8t5qvY3uFWLKXtBcpSppB4zuATajYVMcs7N3vGHNQotOQpCp0NV8L5Wtggg== X-Received: by 2002:a17:906:9b84:b0:73d:8324:487e with SMTP id dd4-20020a1709069b8400b0073d8324487emr99631ejc.98.1661364001610; Wed, 24 Aug 2022 11:00:01 -0700 (PDT) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com. [209.85.221.45]) by smtp.gmail.com with ESMTPSA id 11-20020a170906308b00b0072abb95eaa4sm1417780ejv.215.2022.08.24.11.00.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 11:00:00 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id bs25so21731706wrb.2 for ; Wed, 24 Aug 2022 11:00:00 -0700 (PDT) X-Received: by 2002:a05:6000:136f:b0:225:2fad:dde7 with SMTP id q15-20020a056000136f00b002252faddde7mr210002wrz.274.1661364000263; Wed, 24 Aug 2022 11:00:00 -0700 (PDT) MIME-Version: 1.0 References: <20220824012624.2826445-1-yury.norov@gmail.com> <20220824012624.2826445-2-yury.norov@gmail.com> In-Reply-To: <20220824012624.2826445-2-yury.norov@gmail.com> From: Linus Torvalds Date: Wed, 24 Aug 2022 10:59:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] lib/find_bit: introduce FIND_FIRST_BIT() macro To: Yury Norov Cc: linux-kernel@vger.kernel.org, Guenter Roeck , Dennis Zhou , Russell King , Catalin Marinas , Andy Shevchenko , Rasmus Villemoes , Alexey Klimov , Kees Cook , Andy Whitcroft Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2022 at 6:26 PM Yury Norov wrote: > > + > +#ifndef word_op > +#define word_op > +#endif > + > +#define FIND_FIRST_BIT(EXPRESSION, size) \ Please just make 'word_op' be an macro argument, the same way 'EXPRESSION' is. That way the LE/BE cases can be handled without any odd tricks. Linus