From: Linus Torvalds <torvalds@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [RESEND PATCH v2] string: uninline memcpy_and_pad
Date: Wed, 3 Nov 2021 11:34:05 -0700 [thread overview]
Message-ID: <CAHk-=wiUtTkstJiEwsedWLaq3WdjfW8=0JD6v0qLAFSfzfWBaA@mail.gmail.com> (raw)
In-Reply-To: <bc18aef2-17ee-dcbc-916c-952794adc658@roeck-us.net>
On Wed, Nov 3, 2021 at 11:03 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Either case, I'll wait for advice from Linus on how to proceed.
It's a completely unimportant function, used in a couple of places,
not performance-sensitive, not security-sensitive, and not worth any
kind of buffer size checking.
And it's breaking the build because being inline somehow confuses the compiler.
It gets out-of-lined.
Kees - once you have gotten all compilers fixed and everybody using
them, you can send a patch to make it inline again.
I estimate that is in about ten years or so.
Linus
next prev parent reply other threads:[~2021-11-03 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:25 [RESEND PATCH v2] string: uninline memcpy_and_pad Guenter Roeck
2021-11-03 17:37 ` Kees Cook
2021-11-03 18:03 ` Guenter Roeck
2021-11-03 18:34 ` Linus Torvalds [this message]
2021-11-03 18:39 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiUtTkstJiEwsedWLaq3WdjfW8=0JD6v0qLAFSfzfWBaA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).