From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jakub Kicinski <kuba@kernel.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, pabeni@redhat.com,
bpf@vger.kernel.org, ast@kernel.org
Subject: Re: [PULL] Networking for v6.3
Date: Tue, 21 Feb 2023 18:46:26 -0800 [thread overview]
Message-ID: <CAHk-=wi_410KZqHwF-WL5U7QYxnpHHHNP-3xL=g_y89XnKc-uw@mail.gmail.com> (raw)
In-Reply-To: <20230221233808.1565509-1-kuba@kernel.org>
On Tue, Feb 21, 2023 at 3:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.3
Ok, so this is a bit nitpicky, but commit c7ef8221ca7d ("ice: use GNSS
subsystem instead of TTY") ends up doing odd things to kernel configs.
My local configuration suddenly grew this:
CONFIG_ICE_GNSS=y
which is pretty much nonsensical.
The reason? It's defined as
config ICE_GNSS
def_bool GNSS = y || GNSS = ICE
and so it gets set even when both GNSS and ICE are both disabled,
because 'n' = 'n'.
Does it end up *mattering*? No. It's only used in the ICE driver, but
it really looks all kinds of odd, and it makes the resulting .config
files illogical.
Maybe I'm the only one who looks at those things. I do it because I
think they are sometimes easier to just edit directly, but also
because for me it's a quick way to see if somebody has sneaked in new
config options that are on by default when they shouldn't be.
I'd really prefer to not have the resulting config files polluted with
nonsensical config options.
I suspect it would be as simple as adding a
depends on ICE != n
to that thing, but I didn't get around to testing that. I thought it
would be better to notify the guilty parties.
Anyway, this has obviously not held up me pulling the networking
changes, and you should just see this as (yet another) sign of "yeah,
Linus cares about those config files to a somewhat unhealthy degree".
Linus
next prev parent reply other threads:[~2023-02-22 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 23:38 [PULL] Networking for v6.3 Jakub Kicinski
2023-02-22 2:46 ` Linus Torvalds [this message]
2023-02-22 3:33 ` Jakub Kicinski
2023-02-22 19:07 ` Alexander Lobakin
2023-02-22 2:50 ` pr-tracker-bot
2023-02-23 17:21 ` Linus Torvalds
2023-02-23 19:06 ` Kalle Valo
2023-02-23 21:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wi_410KZqHwF-WL5U7QYxnpHHHNP-3xL=g_y89XnKc-uw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).