From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bvanassche@acm.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] configfs fix for Linux 5.14
Date: Wed, 14 Jul 2021 13:16:19 -0700 [thread overview]
Message-ID: <CAHk-=wiaGVapioim31weBWs4bnzt7+wdyAx8GNFVgrFCLc-YXg@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wjuDBQdUvaO=XaptgmvE_qeg_EuZjsUZf2vVoXPUMgAvg@mail.gmail.com>
On Wed, Jul 14, 2021 at 1:05 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I hope/think that we always end up checking 'pos' in the VFS layer so
> that this isn't a bug in practice
Yeah, we seem to make sure everything is fine in rw_verify_area().
We do allow negative 'pos' things, but only for files marked with
FMODE_UNSIGNED_OFFSET, which is basically just for variations of
/dev/mem and /proc/<pid>/mem that need the whole 64-bit range.
So it _shouldn't_ be an issue here, but the points about just doing
the legible and safe version stands.
Linus
next prev parent reply other threads:[~2021-07-14 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:33 [GIT PULL] configfs fix for Linux 5.14 Christoph Hellwig
2021-07-14 20:05 ` Linus Torvalds
2021-07-14 20:16 ` Linus Torvalds [this message]
2021-07-16 1:13 ` pr-tracker-bot
2021-08-14 6:59 Christoph Hellwig
2021-08-14 16:27 ` Linus Torvalds
2021-08-14 18:25 ` Bart Van Assche
2021-08-15 20:57 ` Bodo Stroesser
2021-08-14 16:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiaGVapioim31weBWs4bnzt7+wdyAx8GNFVgrFCLc-YXg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).