From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Joerg Roedel <jroedel@suse.de>,
Andrew Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Takashi Iwai <tiwai@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset
Date: Mon, 15 Jun 2020 15:37:52 -0700 [thread overview]
Message-ID: <CAHk-=wid9pjXmafH_-F6TooC9j7nfqKweWbHKzENkk+YHTo=AQ@mail.gmail.com> (raw)
In-Reply-To: <20200615222427.60126-1-sashal@kernel.org>
On Mon, Jun 15, 2020 at 3:24 PM Sasha Levin <sashal@kernel.org> wrote:
>
> When a user tries to parse a symbol located inside a module he must have
> modpath set. Otherwise, decode_stacktrace won't be able to parse the
> symbol correctly.
>
> Right now the failure is silent and easily missed by the user. What's
> worse is that by the time the user realizes what happened (or someone on
> LKML asks him to add the modpath and re-run), he might have already got
> rid of the vmlinux/modules.
Well, that looks straightforward.
Applied,
Linus
next prev parent reply other threads:[~2020-06-15 22:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 18:48 Linux 5.8-rc1 BUG unable to handle page fault (snd_pcm) Shuah Khan
2020-06-15 19:47 ` David Rientjes
2020-06-15 19:48 ` Linus Torvalds
2020-06-15 20:41 ` Shuah Khan
2020-06-15 20:55 ` Linus Torvalds
2020-06-15 21:18 ` Shuah Khan
2020-06-15 22:23 ` Linus Torvalds
2020-06-15 22:24 ` [PATCH] scripts/decode_stacktrace: warn when modpath is needed but is unset Sasha Levin
2020-06-15 22:37 ` Linus Torvalds [this message]
2020-06-15 22:43 ` Linus Torvalds
2020-06-15 23:24 ` Sasha Levin
2020-06-15 19:57 ` Linux 5.8-rc1 BUG unable to handle page fault (snd_pcm) Takashi Iwai
2020-06-15 20:53 ` Shuah Khan
2020-06-15 21:04 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wid9pjXmafH_-F6TooC9j7nfqKweWbHKzENkk+YHTo=AQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=jroedel@suse.de \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).