Re: [GIT PULL] keys: Collected minor fixes and cleanups

From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: "Jarkko Sakkinen" <jarkko@kernel.org>,
	"Alexander A. Klimov" <grandmaster@al2klimov.de>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Alex Shi" <alex.shi@linux.alibaba.com>,
	"Ben Boeckel" <mathstuf@gmail.com>,
	"Denis Efremov" <efremov@linux.com>,
	"Gabriel Krisman Bertazi" <krisman@collabora.com>,
	"Jann Horn" <jannh@google.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Mickaël Salaün" <mic@linux.microsoft.com>,
	"Mimi Zohar" <zohar@linux.vnet.ibm.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Tianjia Zhang" <tianjia.zhang@linux.alibaba.com>,
	"Tom Rix" <trix@redhat.com>, YueHaibing <yuehaibing@huawei.com>,
	keyrings@vger.kernel.org,
	"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"LSM List" <linux-security-module@vger.kernel.org>
Subject: Re: [GIT PULL] keys: Collected minor fixes and cleanups
Date: Mon, 14 Dec 2020 12:49:27 -0800	[thread overview]
Message-ID: <CAHk-=wido5stGfFtRzmW19bB1w2XQAuY8oxUtFN2ZWdk2Grq-w@mail.gmail.com> (raw)
In-Reply-To: <2659836.1607940186@warthog.procyon.org.uk>

On Mon, Dec 14, 2020 at 2:04 AM David Howells <dhowells@redhat.com> wrote:
>
> Here's a set of minor fixes/cleanups that I've collected from various
> people for the next merge window.

This doesn't even build.

And no, that's not because of some merge error on my part. Just to
verify, I tried to build the head of what you sent me (commit
1b91ea77dfeb: "certs: Replace K{U,G}IDT_INIT() with
GLOBAL_ROOT_{U,G}ID") and it fails the same way.

  In file included from ./include/linux/cred.h:13,
                   from security/integrity/ima/ima_mok.c:12:
  security/integrity/ima/ima_mok.c: In function ‘ima_mok_init’:
  ./include/linux/key.h:292:29: warning: passing argument 7 of
‘keyring_alloc’ makes pointer from integer without a cast
[-Wint-conversion]
  .. ten more lines of warnings..
  security/integrity/ima/ima_mok.c:36:26: error: too many arguments to
function ‘keyring_alloc’
     36 |  ima_blacklist_keyring = keyring_alloc(".ima_blacklist",
        |                          ^~~~~~~~~~~~~

so these "fixes" have clearly had absolutely zero testing, haven't
been in linux-next, and are completely broken.

The bug was introduced by commit 33c36b2053de ("certs: Fix blacklist
flag type confusion"), which changed the IMA code without actually
testing it.

I suspect the fix is trivial (change the "," to "|"), but I will not
be pulling this - or anything else that hasn't been in linux-next -
from you this merge window.

The pain just isn't worth it, but more importantly, you simply need to
get your workflow in order, and not send me completely untested
garbage that hasn't even been compiled.

               Linus