From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48EBC43611 for ; Fri, 14 May 2021 19:23:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C783C6145D for ; Fri, 14 May 2021 19:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233719AbhENTY3 (ORCPT ); Fri, 14 May 2021 15:24:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhENTYZ (ORCPT ); Fri, 14 May 2021 15:24:25 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91793C061574 for ; Fri, 14 May 2021 12:23:11 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id n2so242994ejy.7 for ; Fri, 14 May 2021 12:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=aWXI51EnV/k9pge5GKaDOkkJQD5K/MYP7A5XMnLlSW2Sy2l/sTiI3B9cP8d8ZTB5m2 R3v2CKeD8i8Tb7rfnKNvLFWu6ekM3Dp1YyH8ufyfZgWCClPGJSZE/oeAn63KZeLaEQ45 fGizC1SmBVw+3SgkMIXS5j/6qsc7gTws56N4g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l72hh61/tsn5KiliU7+ZN3a6OPF8Vv4B7h1Pke4bt3c=; b=Rjeq3BIisiiv/uXSvdtnLkU1uZ0hir717CERRGVdFlyNM09fPPA1tz/TPNKklY9nAK X7/DFgTPSrbNNVA6IG0Qlpox0Yjtkb1z185SbJ97WFPnWWbe4Zd9/HHoZNV3gJs9h30t w7QYDa0CZUOT6ANDONQp9l8Uj+v5ihZqLGkvxxXzYej23ksr85IR0AFP1AQDBLslkJxQ l6pA4WYajp7x9mFSC0RpeULg9Zdw6pXzKqBfm5y0l6/t0pXX2a65vaZnx+usv9aZb50w QmdR35M+hvjXzSSDHKY/pKu5BaU4tEbY/D5LGZJH7Gu3sEc+RCmsoN9VFTNJVdSfCWik ADzg== X-Gm-Message-State: AOAM531mMbk0KgnNfIg1ci7ubRuTaPg3xp1C30QP4E16suB58ZQTYAyT Y8dQxAJCG5UZFmBUS7MA+785R5TVswDhXnqGYGo= X-Google-Smtp-Source: ABdhPJxaKNHOJEn7GQn+V0VCXLJoIw/tn8Ra0G3r0NYnBJqqlHZBzyDIoiATGm5YznEr8jQw4mW2oQ== X-Received: by 2002:a17:906:355a:: with SMTP id s26mr48622726eja.528.1621020190149; Fri, 14 May 2021 12:23:10 -0700 (PDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com. [209.85.221.53]) by smtp.gmail.com with ESMTPSA id b5sm4897590edz.88.2021.05.14.12.23.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:23:09 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id q5so290612wrs.4 for ; Fri, 14 May 2021 12:23:08 -0700 (PDT) X-Received: by 2002:a05:651c:33a:: with SMTP id b26mr40099556ljp.220.1621020178319; Fri, 14 May 2021 12:22:58 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> In-Reply-To: <2408c893-4ae7-4f53-f58c-497c91f5b034@synopsys.com> From: Linus Torvalds Date: Fri, 14 May 2021 12:22:42 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Vineet Gupta Cc: Arnd Bergmann , linux-arch , Arnd Bergmann , Amitkumar Karwar , Benjamin Herrenschmidt , Borislav Petkov , Eric Dumazet , Florian Fainelli , Ganapathi Bhat , Geert Uytterhoeven , "H. Peter Anvin" , Ingo Molnar , Jakub Kicinski , James Morris , Jens Axboe , John Johansen , Jonas Bonn , Kalle Valo , Michael Ellerman , Paul Mackerras , Rich Felker , "Richard Russon (FlatCap)" , Russell King , "Serge E. Hallyn" , Sharvari Harisangam , Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Vladimir Oltean , Xinming Hu , Yoshinori Sato , "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux ARM , linux-m68k , Linux Crypto Mailing List , "openrisc@lists.librecores.org" , linuxppc-dev , Linux-sh list , linux-sparc , "linux-ntfs-dev@lists.sourceforge.net" , linux-block , linux-wireless , Netdev , LSM List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 11:52 AM Vineet Gupta wrote: > > Wasn't the new zlib code slated for 5.14. I don't see it in your master yet You're right, I never actually committed it, since it was specific to ARC and -O3 and I wasn't entirely happy with the amount of testing it got (with Heiko pointing out that the s390 stuff needed more fixes for the change). So in fact it's not even queued up for 5.14 due to this all, I just dropped it. > > and the biggy > > case didn't even use "get_unaligned()"). > > Indeed this series is sort of orthogonal to that bug, but IMO that bug > still exists in 5.13 for -O3 build, granted that is not enabled for !ARC. Right, the zlib bug is still there. But Arnd's series wouldn't even fix it: right now inffast has its own - ugly and slow - special 2-byte-only version of "get_unaligned()", called "get_unaligned16()". And because it's ugly and slow, it's not actually used for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Vineet - maybe the fix is to not take my patch to update to a newer zlib, but to just fix inffast to use the proper get_unaligned(). Then Arnd's series _would_ actually fix all this.. Linus