archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Steven Rostedt <>
Cc: LKML <>,
	Ingo Molnar <>,
	Andrew Morton <>
Subject: Re: [GIT PULL] tracing: Updates for 5.2
Date: Wed, 15 May 2019 16:29:50 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190515133614.31dcbbe0@oasis.local.home>

On Wed, May 15, 2019 at 10:36 AM Steven Rostedt <> wrote:
> The major changes in this tracing update includes:

This is not directly related to this pull request, but newer versions
of gcc hate your trace_iterator clearing trick.

This code:

                /* reset all but tr, trace, and overruns */
                memset(&iter.seq, 0,
                       sizeof(struct trace_iterator) -
                       offsetof(struct trace_iterator, seq));

not only has a completely misleading comment (it resets a lot more
than the comment states), but modern gcc looks at that code and says
"oh, you're passing it a pointer to 'iter.seq', but then clearing a
lot more than a 'trace_seq'":

  In function ‘memset’,
      inlined from ‘ftrace_dump’ at kernel/trace/trace.c:8914:3:
 /include/linux/string.h:344:9: warning: ‘__builtin_memset’ offset
[8505, 8560] from the object at ‘iter’ is out of the bounds of
referenced subobject ‘seq’ with type ‘struct trace_seq’ at offset 4368
    344 |  return __builtin_memset(p, c, size);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

It's a somewhat annoying warning because the code itself is
technically correct, but at the same time, I think the gcc warning is
reasonable. You *are* passing it a 'struct trace_seq' pointer, and
then you're clearing a whole lot more than that.

One option is to just rewrite it something like

        const unsigned int offset = offsetof(struct trace_iterator, seq);
        memset(offset+(void *)&iter, 0, sizeof(iter) - offset);

which should compile cleanly - because now you're doing the memset on
a part of the much bigger 'iter' structure, not on one member (and
overflowing that one member).

Another option might be to separate the zeroed part of the structure
into a sub-structure of its own, and then just use

        memset(&iter.sub, 0, sizeof(iter.sub));

but then you'd obviously have to change all the uses of the sub-fields..


  reply	other threads:[~2019-05-15 23:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 17:36 Steven Rostedt
2019-05-15 23:29 ` Linus Torvalds [this message]
2019-05-15 23:31   ` Linus Torvalds
2019-05-16  0:27     ` Steven Rostedt
2019-05-16  1:21       ` Linus Torvalds
2019-05-16  9:08   ` David Laight
2019-05-15 23:50 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \
    --subject='Re: [GIT PULL] tracing: Updates for 5.2' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).