From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Nicolai Stange <nstange@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mimi Zohar <zohar@linux.ibm.com>, Juergen Gross <jgross@suse.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Nayna Jain <nayna@linux.ibm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Joerg Roedel <jroedel@suse.de>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions
Date: Thu, 2 May 2019 11:02:40 -0700 [thread overview]
Message-ID: <CAHk-=wijZ-MD4g3zMJ9W2r=h8LUWneiu29OWuxZEoSfAF=0bhQ@mail.gmail.com> (raw)
In-Reply-To: <20190502162133.GX2623@hirez.programming.kicks-ass.net>
On Thu, May 2, 2019 at 9:21 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> TL;DR, on x86_32 kernel->kernel IRET frames are only 3 entries and do
> not include ESP/SS, so not only wasn't regs->sp setup, if you changed it
> it wouldn't be effective and corrupt random stack state.
Indeed, the 32-bit case for same-RPL exceptions/iret is entirely
different, and I'd forgotten about that.
And honestly, this makes the 32-bit case much worse. Now the entry
stack modifications of int3 suddenly affect not just the entry, but
every exit too.
This is _exactly_ the kind of subtle kernel entry/exit code I wanted
us to avoid.
And while your code looks kind of ok, it's subtly buggy. This sequence:
+ pushl %eax
+ movl %esp, %eax
+
+ movl 4*4(%eax), %esp # restore (modified) regs->sp
+
+ /* rebuild IRET frame */
+ pushl 3*4(%eax) # flags
+ pushl 2*4(%eax) # cs
+ pushl 1*4(%eax) # ip
+
+ andl $0x0000ffff, 4(%esp) # clear high CS bits
+
+ movl (%eax), %eax # restore eax
looks very wrong to me. When you do that "restore (modified)
regs->sp", isn't that now resetting %esp to the point where %eax now
points below the stack? So if we get an NMI in this sequence, that
will overwrite the parts you are trying to copy from?
Am I missing something? doesn't it need to be done something like
pushl %eax
pushl %ecx
movl 20(%esp),%eax # possibly modified regs->sp
movl 16(%esp),%ecx # flags
movl %ecx,-4(%eax)
movl 12(%esp),%ecx # cs
movl %ecx,-8(%eax)
movl 8(%esp),%ecx # ip
movl %ecx, -12(%eax)
movl 4(%esp),%ecx # eax
movl %ecx, -16(%eax)
popl %ecx
lea -16(%eax),%esp
popl %eax
(NOTE NOTE NOTE I might have gotten the offsets and the direction of
the moves *completely* wrong, this is not a serious patch, it's meant
as a "something like this" thing!!)
But now I confused myself, and maybe I'm wrong.
Linus
next prev parent reply other threads:[~2019-05-02 18:03 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 20:28 [RFC][PATCH 0/2] ftrace/x86: Allow for breakpoint handlers to emulate call functions Steven Rostedt
2019-05-01 20:28 ` [RFC][PATCH 1/2] x86: Allow breakpoints " Steven Rostedt
2019-05-02 3:24 ` Steven Rostedt
2019-05-02 16:21 ` Peter Zijlstra
2019-05-02 16:29 ` Peter Zijlstra
2019-05-02 18:02 ` Linus Torvalds [this message]
2019-05-02 18:18 ` Peter Zijlstra
2019-05-02 18:30 ` Peter Zijlstra
2019-05-02 18:43 ` Linus Torvalds
2019-05-02 19:28 ` Jiri Kosina
2019-05-02 20:25 ` Andy Lutomirski
2019-05-02 20:21 ` Peter Zijlstra
2019-05-02 20:49 ` Linus Torvalds
2019-05-02 21:32 ` Peter Zijlstra
2019-05-03 19:24 ` Steven Rostedt
2019-05-03 21:46 ` Linus Torvalds
2019-05-03 22:49 ` Steven Rostedt
2019-05-03 23:07 ` Linus Torvalds
2019-05-04 4:17 ` Steven Rostedt
[not found] ` <CAHk-=wiuSFbv_rELND-BLWcP0GSZ0yF=xOAEcf61GE3bU9d=yg@mail.gmail.com>
2019-05-04 18:59 ` Linus Torvalds
2019-05-04 20:12 ` Andy Lutomirski
2019-05-04 20:28 ` Linus Torvalds
2019-05-04 20:36 ` Linus Torvalds
2019-05-03 22:55 ` Andy Lutomirski
2019-05-03 23:16 ` Linus Torvalds
2019-05-03 23:32 ` Andy Lutomirski
2019-05-02 22:52 ` Steven Rostedt
2019-05-02 23:31 ` Steven Rostedt
2019-05-02 23:50 ` Steven Rostedt
2019-05-03 1:51 ` [RFC][PATCH 1/2 v2] " Steven Rostedt
2019-05-03 9:29 ` [RFC][PATCH 1/2] " Peter Zijlstra
2019-05-03 13:22 ` Steven Rostedt
2019-05-03 16:20 ` Andy Lutomirski
2019-05-03 16:31 ` Steven Rostedt
2019-05-03 16:35 ` Peter Zijlstra
2019-05-03 16:44 ` Andy Lutomirski
2019-05-03 16:49 ` Steven Rostedt
2019-05-03 16:32 ` Peter Zijlstra
2019-05-03 18:57 ` Linus Torvalds
2019-05-06 8:19 ` Peter Zijlstra
2019-05-06 13:56 ` Steven Rostedt
2019-05-06 16:17 ` Linus Torvalds
2019-05-06 16:19 ` Linus Torvalds
2019-05-06 17:06 ` Steven Rostedt
2019-05-06 18:06 ` Linus Torvalds
2019-05-06 18:57 ` Steven Rostedt
2019-05-06 19:46 ` Linus Torvalds
2019-05-06 20:29 ` Steven Rostedt
2019-05-06 20:42 ` Linus Torvalds
2019-05-06 20:44 ` Linus Torvalds
2019-05-06 21:45 ` Steven Rostedt
2019-05-06 22:06 ` Linus Torvalds
2019-05-06 22:31 ` Linus Torvalds
2019-05-07 0:10 ` Steven Rostedt
2019-05-07 1:06 ` Linus Torvalds
2019-05-07 1:04 ` Steven Rostedt
2019-05-07 1:34 ` Steven Rostedt
2019-05-07 1:34 ` Linus Torvalds
2019-05-07 1:53 ` Steven Rostedt
2019-05-07 2:22 ` Linus Torvalds
2019-05-07 2:58 ` Steven Rostedt
2019-05-07 3:05 ` Linus Torvalds
2019-05-07 3:21 ` Steven Rostedt
2019-05-07 3:28 ` Linus Torvalds
2019-05-07 14:54 ` Linus Torvalds
2019-05-07 15:12 ` Steven Rostedt
2019-05-07 15:25 ` Steven Rostedt
2019-05-07 16:25 ` Steven Rostedt
2019-05-07 15:31 ` Linus Torvalds
2019-05-07 15:45 ` Steven Rostedt
2019-05-07 16:34 ` Peter Zijlstra
2019-05-07 17:08 ` Linus Torvalds
2019-05-07 17:21 ` Josh Poimboeuf
2019-05-07 21:24 ` Steven Rostedt
2019-05-08 4:50 ` Linus Torvalds
2019-05-08 16:37 ` Steven Rostedt
2019-05-07 17:38 ` Peter Zijlstra
2019-05-07 9:51 ` Peter Zijlstra
2019-05-07 14:48 ` Andy Lutomirski
2019-05-07 14:57 ` Linus Torvalds
2019-05-07 14:13 ` Masami Hiramatsu
2019-05-07 17:15 ` Masami Hiramatsu
2019-05-06 14:22 ` Peter Zijlstra
2019-05-07 8:57 ` Peter Zijlstra
2019-05-07 9:18 ` David Laight
2019-05-07 11:30 ` Peter Zijlstra
2019-05-07 12:57 ` David Laight
2019-05-07 13:14 ` Steven Rostedt
2019-05-07 14:50 ` David Laight
2019-05-07 14:57 ` Steven Rostedt
2019-05-07 15:46 ` David Laight
2019-05-07 13:32 ` Peter Zijlstra
2019-05-07 9:27 ` Peter Zijlstra
2019-05-07 12:27 ` Steven Rostedt
2019-05-07 12:41 ` Peter Zijlstra
2019-05-07 12:54 ` Steven Rostedt
2019-05-07 17:22 ` Masami Hiramatsu
2019-05-07 14:28 ` Peter Zijlstra
2019-05-02 20:48 ` Steven Rostedt
2019-05-06 15:14 ` Josh Poimboeuf
2019-05-01 20:28 ` [RFC][PATCH 2/2] ftrace/x86: Emulate call function while updating in breakpoint handler Steven Rostedt
2019-05-03 10:22 ` [RFC][PATCH 1.5/2] x86: Add int3_emulate_call() selftest Peter Zijlstra
2019-05-03 18:46 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wijZ-MD4g3zMJ9W2r=h8LUWneiu29OWuxZEoSfAF=0bhQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nayna@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=nstange@suse.de \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).