From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 972F67BAF0 for ; Mon, 29 Apr 2024 15:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714405892; cv=none; b=Q4IxioZeHJYzJxK62U6JjTpHAlmsegJyAATrqLrmyXStIXsOlRKYrLyHhbPfxGJqP0bcvRgJNYy7j8TNpomijJ/08PeBdMfO08Yv1WR4VzVuqvzYTBJ6Mga+w/zs35SUTfroFxMxaFuVLHlolBWjiBn/WcSirbK/RoZIdujH9Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714405892; c=relaxed/simple; bh=D+lhvJrYhUxu/0pChQYcmnU7oKvWHnEID0aAXtlOzO0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LmYepbRYPWmNj1bPIyOB0ldjq43GHNZkF6E3NLoZGEgKyFQvR9/ypo2FV5xtBQlomMg2QY4gjVtpHtdYMzlA1/iaEC9Z2znu95CxtlB8PF/sI7EwytGQ//d1ciUdMmXntn6SkpCfVdbRzAJWLnkIFN+q+dhrezbAeXJ0neoKTMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=QgzRthGE; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="QgzRthGE" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5708d8beec6so5793920a12.0 for ; Mon, 29 Apr 2024 08:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1714405889; x=1715010689; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lXasHxM1egr/YdHGYASIzG/58nZx0kha5r74ZHvQjpw=; b=QgzRthGEZDs7SX2U7FD5DpJQtnz2zu7lNNEu/Ok8VNXHadLIZrPSVm7qAWvuhd93nt TV14pynJ4+p9HjL88FS28O+0t3Y0EpfV14/hVa03AXzfecIO5775zAUCkTvQHNOrop6Y VpA6rZqVZbco6b5Ey4ntPm9h5wUtQsqngncZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714405889; x=1715010689; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lXasHxM1egr/YdHGYASIzG/58nZx0kha5r74ZHvQjpw=; b=Dfs+HfmH9bQKdl1cT4VkQZb+iwTyj3RZsKPJA8fyGLh2Laz5VJ7CObk04hSNyjKgBU 7qKpsGcilsEnqL/jVAmEUw9CRROzaK7UiVuBp++9ZRHhFAm3o18mQennwuoBrLsA1Af9 JjVxS7wW1kLQqKbwsGxujwmgo13I1onSo4rbemCXJhbcGQj/PcUe8OqcnT3mjam9mBey wKttaEjzTzvE05RDDmgts0XISvSVsIB/CmU0SWfwG6T4fp7M3EhuGPcOT1Tkdr3CfBUN oH8HU+nsZbRUNwHWY9g4WaA/63bjGAUUXAvyAlaWxWYn87EiRfSm03EZEaPhWUY0hLXa c1pw== X-Forwarded-Encrypted: i=1; AJvYcCVhIaEyYOdqJdRNp/5vZe/EzFV4fZj3dl4zFsCaTNqkqr65MoDyGmB1IX43eOBomY+IwLdiLD43ZuHr8A09bUnX+g5yWpsuNmfXIcBJ X-Gm-Message-State: AOJu0YzPnmJLQ5o9gsbMJSXO7Kuz59vMRZKSutm6KQVbgtB1ZCdotOJ/ NeSIdN3tci7z/scOcx5O81AJZok34eHbCpmrnY33Pf4dU1PC/C3+0Iotg3j/CwtcNCz0SkPLCYm vN8Gt4g== X-Google-Smtp-Source: AGHT+IGBES3PEMyD7pRck4jc6Xxx1FwvX2XD4dD/n9AhptpfW7iIHQoCDWYyuCh3yLRnRJA7E4jypw== X-Received: by 2002:a17:907:76c2:b0:a55:b2da:3e92 with SMTP id kf2-20020a17090776c200b00a55b2da3e92mr8831878ejc.68.1714405888870; Mon, 29 Apr 2024 08:51:28 -0700 (PDT) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id eb16-20020a170907281000b00a58764e6c45sm8279513ejc.173.2024.04.29.08.51.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 08:51:28 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a5200202c1bso623995866b.0 for ; Mon, 29 Apr 2024 08:51:27 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU4MM3rC7QqhqqvRD3y41yxUehWIz1FRAsl1C8bebFBU4XN84fyDaXCMZOtGfqUcxVswlOSjtLfwB+A8OMB2e8pJ8QJVCzjvQIjFI00 X-Received: by 2002:a17:907:7890:b0:a55:54ec:a2fe with SMTP id ku16-20020a170907789000b00a5554eca2femr8987483ejc.29.1714405887417; Mon, 29 Apr 2024 08:51:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <0000000000009dfa6d0617197994@google.com> <20240427231321.3978-1-hdanton@sina.com> <20240428232302.4035-1-hdanton@sina.com> In-Reply-To: From: Linus Torvalds Date: Mon, 29 Apr 2024 08:51:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] x86/mm: Remove broken vsyscall emulation code from the page fault code To: Ingo Molnar Cc: Hillf Danton , Andy Lutomirski , Peter Anvin , Adrian Bunk , syzbot , Tetsuo Handa , andrii@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 29 Apr 2024 at 01:00, Ingo Molnar wrote: > > I did some Simple Testing=E2=84=A2, and nothing seemed to break in any wa= y visible > to me, and the diffstat is lovely: > > 3 files changed, 3 insertions(+), 56 deletions(-) > > Might stick this into tip:x86/mm and see what happens? Well, Hilf had it go through the syzbot testing, and Jiri seems to have tested it on his setup too, so it looks like it's all good, and you can change the "Not-Yet-Signed-off-by" to be a proper sign-off from me. It would be good to have some UML testing done, but at the same time I do think that anybody running UML on modern kernels should be running a modern user-mode setup too, so while the exact SIGSEGV details may have been an issue in 2011, I don't think it's reasonable to think that it's an issue in 2024. Linus