linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] NIOS2: fix for v5.15, part 2
Date: Wed, 20 Oct 2021 06:02:23 -1000	[thread overview]
Message-ID: <CAHk-=wj=eUah6C8Zj4z2OzbFGn0Oxtg9cqvYs1kD-=qPj0dYBw@mail.gmail.com> (raw)
In-Reply-To: <20211018195945.2462739-1-dinguyen@kernel.org>

On Mon, Oct 18, 2021 at 9:59 AM Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> - Renamed CTL_STATUS to CTL_FSTATUS to fix a redefined warning

Hmm. That's still some very generic names exposed in a arch header
file that seems to get included (indirectly) almost everywhere.

I've pulled this, but I would suggest you name those flags not "CTL"
but something that is more exclusive to nios2.

Btw, the same goes for some of the other macros in there that are
currently unique - like "RDCTL". That's a name that I can see a driver
using internally, and with nios2 being so unusual, it would take
potentially a longish time before anybody even noticed.

            Linus

  reply	other threads:[~2021-10-20 16:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 19:59 [GIT PULL] NIOS2: fix for v5.15, part 2 Dinh Nguyen
2021-10-20 16:02 ` Linus Torvalds [this message]
2021-10-20 16:16 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wj=eUah6C8Zj4z2OzbFGn0Oxtg9cqvYs1kD-=qPj0dYBw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).