From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F721C432BE for ; Wed, 1 Sep 2021 19:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C5086101B for ; Wed, 1 Sep 2021 19:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbhIATCW (ORCPT ); Wed, 1 Sep 2021 15:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244983AbhIATCO (ORCPT ); Wed, 1 Sep 2021 15:02:14 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F206C0613C1 for ; Wed, 1 Sep 2021 12:01:17 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id t19so1033411lfe.13 for ; Wed, 01 Sep 2021 12:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=npd1RU7mbNsF3k0GeBkr9d4yP6Ob5CEAADTVG3CYCjw=; b=ErHaIpxZiEMxxjypsttdmUORwYq4vP1VZ+xYSjVl8afEmUE0mZp3Aj9x4LVzPgegFp QxCWY5+Gxwtt2L2qth2RgEkh1nozrNfG4UGJESfbueNOy10Bzrii0P8RVC60ibu3uR99 Ri6W/fH6hsL0OtQOBkjpL0U0EcWE6CxP3PMa4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=npd1RU7mbNsF3k0GeBkr9d4yP6Ob5CEAADTVG3CYCjw=; b=Hy/TJe1jNKkRCVpSc0AFAil0DJmKlypXIqFl2tX5/8mcxTiBGhZ/p/juT0MDiqX//O l1DnsNIlYqOzEECujbFazA80ttN5K4E0ztDE5cqJC7egPs5JbSLsNQ8+J7ILglDpLdeE Y6+1f8nXp5XDFPkpHyGPrJIFu7cx9LJOhCqlAWIcYLHpcDdayQYkZgizwJrzPepUTU7P M6O5XmXhNSyrOjzhxBv5ADge3tDZfkBIkS/nRFMRgASG0EDeucqTLQLKbk+LriC92E0u NujIxTSUwpvfoMtXULclLz4vo3c1Ga8YaJ9KIMoJswzoo6VcwN/2lDtUpEsDd7fb9Fru uMLw== X-Gm-Message-State: AOAM5333ROTy0McDPimxS88xJInHAYRt1qxkD8TOr9vJR3/J4VWOXqQq W02Sm5CaSI9mzpoyCPAMYi0tVjf0NF87/QBE X-Google-Smtp-Source: ABdhPJwqJXhGTgyddOtotVk7XboI0KL+uIZ88kvApBaG7EJ8eyIgwTzAtjDzweICnxblS2U2dZwieQ== X-Received: by 2002:a05:6512:32ca:: with SMTP id f10mr629199lfg.557.1630522874671; Wed, 01 Sep 2021 12:01:14 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id j20sm31304lfr.248.2021.09.01.12.01.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 12:01:14 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id i28so761759ljm.7 for ; Wed, 01 Sep 2021 12:01:13 -0700 (PDT) X-Received: by 2002:a2e:3004:: with SMTP id w4mr888035ljw.465.1630522873162; Wed, 01 Sep 2021 12:01:13 -0700 (PDT) MIME-Version: 1.0 References: <20210831203727.3852294-1-kuba@kernel.org> In-Reply-To: <20210831203727.3852294-1-kuba@kernel.org> From: Linus Torvalds Date: Wed, 1 Sep 2021 12:00:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Networking for v5.15 To: Jakub Kicinski , Luca Coelho , Kalle Valo Cc: David Miller , Netdev , Linux Kernel Mailing List , Greg Kroah-Hartman , linux-wireless Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski wrote: > > No conflicts at the time of writing. There were conflicts with > char-misc but I believe Greg dropped the commits in question. Hmm. I already merged this earlier, but didn't notice a new warning on my desktop: RTNL: assertion failed at net/wireless/reg.c (4025) WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:4025 regulatory_set_wiphy_regd_sync+0x7f/0x90 [cfg80211] Call Trace: iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/reg.c (3106) WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:3106 reg_process_self_managed_hint+0x26c/0x280 [cfg80211] Call Trace: regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/core.c (84) WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:84 wiphy_idx_to_wiphy+0x97/0xd0 [cfg80211] Call Trace: nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] reg_process_self_managed_hint+0x23d/0x280 [cfg80211] regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] and RTNL: assertion failed at net/wireless/core.c (61) WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61 wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211] Call Trace: nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] reg_process_self_managed_hint+0x23d/0x280 [cfg80211] regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] They all seem to have that same issue, and it looks like the fix would be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look into it very much. This is on my desktop, and I actually don't _use_ the wireless on this machine. I assume it still works despite the warnings, but they should get fixed. I *don't* see these warnings on my laptop where I actually use wireless, but that one uses ath10k_pci, so it seems this is purely a iwlwifi issue. I can't be the only one that sees this. Hmm? Linus