From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [GIT PULL] fallthrough fixes for Clang for 5.14-rc2
Date: Fri, 16 Jul 2021 12:26:27 -0700 [thread overview]
Message-ID: <CAHk-=wjGfJPROMSdC8n1xnvyQzxWiz2pXV9E6OE_vpti7rCdZQ@mail.gmail.com> (raw)
In-Reply-To: <7774f876-6a60-03e4-b273-34f508d06404@kernel.org>
On Fri, Jul 16, 2021 at 12:18 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> Hence why I suggested -Wimplicit-fallthrough-unreachable.
As long as it's a warning that the kernel would never set, that's fine.
I think it's an entirely bogus warning, but at some point as long as
we don't need to care about it, we can happily ignore it.
Or just continue to say "clang is spewing bogus warnings, don't use it".
But the sane naming for that warning should certainly not have
anything at all to do with "implicit". Quite the reverse. The warning
is about an _explicit_ fallthrough being unreachable, and as such
thje warning name should reflect that.
So make it just "-Wfallthrough-unreachable" (maybe even
"-Wexplicit-..") to allow people who want that pointless warning to
enable it.
Linus
next prev parent reply other threads:[~2021-07-16 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 20:05 [GIT PULL] fallthrough fixes for Clang for 5.14-rc2 Gustavo A. R. Silva
2021-07-15 21:15 ` pr-tracker-bot
2021-07-16 1:04 ` Linus Torvalds
2021-07-16 1:16 ` Gustavo A. R. Silva
2021-07-16 1:22 ` Linus Torvalds
2021-07-16 1:29 ` Gustavo A. R. Silva
2021-07-16 18:47 ` Nathan Chancellor
2021-07-16 18:57 ` Gustavo A. R. Silva
2021-07-16 19:18 ` Nathan Chancellor
2021-07-16 19:26 ` Linus Torvalds [this message]
2021-07-16 19:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjGfJPROMSdC8n1xnvyQzxWiz2pXV9E6OE_vpti7rCdZQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).