From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Nicolai Stange <nstange@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mimi Zohar <zohar@linux.ibm.com>, Juergen Gross <jgross@suse.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Nayna Jain <nayna@linux.ibm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andy Lutomirski <luto@kernel.org>, Joerg Roedel <jroedel@suse.de>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
live-patching@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation
Date: Mon, 29 Apr 2019 14:38:35 -0700 [thread overview]
Message-ID: <CAHk-=wjGquN7-kQCoa+LHCuiVTjefkk38qwaysd4wLLtoSZhpg@mail.gmail.com> (raw)
In-Reply-To: <20190429163043.535f4272@gandalf.local.home>
On Mon, Apr 29, 2019 at 1:30 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> The update from "call custom_trampoline" to "call iterator_trampoline"
> is where we have an issue.
So it has never worked. Just tell people that they have two chocies:
- you do the careful rewriting, which takes more time
- you do it by rewriting as nop and then back, which is what
historically has been done, and that is fast and simple, because
there's no need to be careful.
Really. I find your complaints completely incomprehensible. You've
never rewritten call instructions atomically before, and now you
complain about it being slightly more expensive to do it when I give
you the code? Yes it damn well will be slightly more expensive. Deal
with it.
Btw, once again - I several months ago also gave a suggestion on how
it could be done batch-mode by having lots of those small stubs and
just generating them dynamically.
You never wrote that code *EITHER*. It's been *months*.
So now I've written the non-batch-mode code for you, and you just
*complain* about it?
I'm done with this discussion. I'm totally fed up.
Linus
next prev parent reply other threads:[~2019-04-29 21:39 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 10:06 [PATCH 0/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation Nicolai Stange
2019-04-27 10:06 ` [PATCH 1/4] x86/thread_info: introduce ->ftrace_int3_stack member Nicolai Stange
2019-04-28 17:41 ` Andy Lutomirski
2019-04-28 17:51 ` Steven Rostedt
2019-04-28 18:08 ` Andy Lutomirski
2019-04-28 19:43 ` Steven Rostedt
2019-04-28 20:56 ` Andy Lutomirski
2019-04-28 21:22 ` Nicolai Stange
2019-04-28 23:27 ` Andy Lutomirski
2019-04-27 10:06 ` [PATCH 2/4] ftrace: drop 'static' qualifier from ftrace_ops_list_func() Nicolai Stange
2019-04-27 10:06 ` [PATCH 3/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation Nicolai Stange
2019-04-27 10:26 ` Peter Zijlstra
2019-04-28 17:38 ` Steven Rostedt
2019-04-29 18:06 ` Linus Torvalds
2019-04-29 18:22 ` Linus Torvalds
2019-04-29 18:42 ` Andy Lutomirski
[not found] ` <CAHk-=whtt4K2f0KPtG-4Pykh3FK8UBOjD8jhXCUKB5nWDj_YRA@mail.gmail.com>
2019-04-29 18:56 ` Andy Lutomirski
[not found] ` <CAHk-=wgewK4eFhF3=0RNtk1KQjMANFH6oDE=8m=84RExn2gxhw@mail.gmail.com>
[not found] ` <CAHk-=whay7eN6+2gZjY-ybRbkbcqAmgrLwwszzHx8ws3c=S-MA@mail.gmail.com>
2019-04-29 19:24 ` Andy Lutomirski
2019-04-29 20:07 ` Linus Torvalds
2019-04-30 13:56 ` Peter Zijlstra
2019-04-30 16:06 ` Linus Torvalds
2019-04-30 16:33 ` Andy Lutomirski
2019-04-30 17:03 ` Steven Rostedt
2019-04-30 17:20 ` Steven Rostedt
2019-04-30 17:49 ` [RFC][PATCH] ftrace/x86: Emulate call function while updating in breakpoint handler Steven Rostedt
2019-04-30 18:33 ` Linus Torvalds
2019-04-30 19:00 ` Steven Rostedt
2019-04-30 21:08 ` Steven Rostedt
2019-05-01 13:11 ` Peter Zijlstra
2019-05-01 18:58 ` Steven Rostedt
2019-05-01 19:03 ` Peter Zijlstra
2019-05-01 19:03 ` Linus Torvalds
2019-05-01 19:13 ` Peter Zijlstra
2019-05-01 19:13 ` Steven Rostedt
2019-05-01 19:33 ` Jiri Kosina
2019-05-01 19:41 ` Peter Zijlstra
2019-04-30 21:53 ` [RFC][PATCH v2] " Steven Rostedt
2019-05-01 1:35 ` Steven Rostedt
2019-05-01 1:58 ` Linus Torvalds
2019-05-01 8:26 ` Nicolai Stange
2019-05-01 13:22 ` Steven Rostedt
2019-04-29 20:16 ` [PATCH 3/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation Linus Torvalds
2019-04-29 22:08 ` Sean Christopherson
2019-04-29 22:22 ` Linus Torvalds
2019-04-30 0:08 ` Sean Christopherson
2019-04-30 0:45 ` Sean Christopherson
2019-04-30 2:26 ` Linus Torvalds
2019-04-30 10:40 ` Peter Zijlstra
2019-04-30 11:17 ` Jiri Kosina
2019-04-29 22:06 ` Linus Torvalds
2019-04-30 11:18 ` Peter Zijlstra
2019-04-29 18:52 ` Steven Rostedt
[not found] ` <CAHk-=wjm93jLtVxTX4HZs6K4k1Wqh3ujjmapqaYtcibVk_YnzQ@mail.gmail.com>
2019-04-29 19:07 ` Steven Rostedt
2019-04-29 20:06 ` Linus Torvalds
2019-04-29 20:20 ` Linus Torvalds
2019-04-29 20:30 ` Steven Rostedt
2019-04-29 21:38 ` Linus Torvalds [this message]
2019-04-29 22:07 ` Steven Rostedt
2019-04-30 9:24 ` Nicolai Stange
2019-04-30 10:46 ` Peter Zijlstra
2019-04-30 13:44 ` Steven Rostedt
2019-04-30 14:20 ` Peter Zijlstra
2019-04-30 14:36 ` Steven Rostedt
2019-04-27 10:06 ` [PATCH 4/4] selftests/livepatch: add "ftrace a live patched function" test Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjGquN7-kQCoa+LHCuiVTjefkk38qwaysd4wLLtoSZhpg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=nayna@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=nstange@suse.de \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).