From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5EAC2BA15 for ; Thu, 2 Apr 2020 20:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFE9020719 for ; Thu, 2 Apr 2020 20:43:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585860220; bh=Tf3E3ksulwamKaWu0vTWkynQVEtf4P/JCu7Tf/XFTDA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rLmMy+S2lAyCoHyVIGU/nTK7+He8ITbB3/9OvJsW+sNYyF/dt6X8J5cG+eIJyWY/Q wCRfgMIe+Jkax8+S/4/BI89kmagUun5Q9gkiO0JSxtnG9ZtOBIFz6unZMUnDQcncIr aHCLfmzrrOjPfOlrNO4TqFkIdDq/IVK6+dp6UTww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388509AbgDBUnj (ORCPT ); Thu, 2 Apr 2020 16:43:39 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39250 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgDBUnj (ORCPT ); Thu, 2 Apr 2020 16:43:39 -0400 Received: by mail-lj1-f195.google.com with SMTP id i20so4717213ljn.6 for ; Thu, 02 Apr 2020 13:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b+sg1IKvR7UQ+P+0PCBeB0y4Q0Z6zSnVzKwNNzIYfpI=; b=BdX1Y/hZi2MjhDmwunvX3GgwarGy7zBfCrMFBwDkrtrvJ7Dt24JOgvxUi6i0qQnp7t paezfz2PsP2dl0MorMvZGKKGypox6m4fxOT6lUKujnk8zz+rs51qD7Va9JFfnTsUPaLr m+jfoJ+31JUR6/cYG8huhVA83tz3nLYvzg4RI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b+sg1IKvR7UQ+P+0PCBeB0y4Q0Z6zSnVzKwNNzIYfpI=; b=NDSYIhaSoCCMA/3WvYG9efCR9H0QSEgnNqngLdfnZT6pN9egoEut4F1GAa8RFN+ODe XDZoNbb0jRXh3G83qqC+nMcj820FScjaD5ctK7Irhbvt7YyPaIcvCMWtQ04p+T56GATq pj36YVxlIi3Zwh3V3R7XZV3pqg1xYuz2GosIYS6IHX066hifftSegpnltQkHXg0fzrCb k1IBNJy6AQIbkRykxI6nHjaRHZboKsxZJ4V3gv48Bi5PiGLxsdUlfpYq2IWJ+sh+n4Qd yhdb8/yMmVKAQ1x3tDF/Bv0aZlzv6NjIVjAFjq2a3E0Vz+y0ejr6VcxwIRdrGGRqr63/ pNGQ== X-Gm-Message-State: AGi0PuYzFuCelCS1NJ8TqpExreqJ9l0C+1p8JJ1WXR5yIAAJtnReGqGx PckrMwBCMOpjPf+eNREVtEaZG70a4WY= X-Google-Smtp-Source: APiQypLoaJSHIYj9i1UvScNSstJnlRy6xSg4wQsGxCr08F15SnAPKaiGryFwhdWeIDZUEQcBvttU+w== X-Received: by 2002:a05:651c:287:: with SMTP id b7mr3044052ljo.129.1585860215612; Thu, 02 Apr 2020 13:43:35 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id x14sm4672022lff.65.2020.04.02.13.43.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2020 13:43:34 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id e7so3950498lfq.1 for ; Thu, 02 Apr 2020 13:43:34 -0700 (PDT) X-Received: by 2002:a19:240a:: with SMTP id k10mr3320923lfk.30.1585860213940; Thu, 02 Apr 2020 13:43:33 -0700 (PDT) MIME-Version: 1.0 References: <20200402203317.GA34560@ubuntu-m2-xlarge-x86> In-Reply-To: <20200402203317.GA34560@ubuntu-m2-xlarge-x86> From: Linus Torvalds Date: Thu, 2 Apr 2020 13:43:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [git pull] drm for 5.7-rc1 To: Nathan Chancellor Cc: Dave Airlie , Daniel Vetter , dri-devel , LKML , Chris Wilson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 2, 2020 at 1:33 PM Nathan Chancellor wrote: > > This fixes it but I am not sure if it is proper or not (could be > problematic if CONFIG_PHYS_ADDR_T_64BIT is set but > CONFIG_ARCH_DMA_ADDR_T_64BIT is not, not sure if that is possible) so I > figured I'd report it and let you guys deal with it. Yeah, no, that patch can't be right. >From your build failure, your configuration has dma_addr_t being a 'long long unsigned int', and map->offset being a resource_size_t is for just a 'unsigned int'. Casting 'unsigned int *' to 'unsigned long long *' is not valid. You'd have to do something like dma_addr_t temp; and pass the address of *that* in, and then assign that to map->offset (and verify that it fits), I think. That's kind of what the old code did. Or alternatively, the 'offset' field should just be of type 'dma_addr_t' instead (see include/drm/drm_legacy.h). But I didn't check if something else wants it to be a resource_size_t. Linus