From: Linus Torvalds <firstname.lastname@example.org> To: Sandeep Patil <email@example.com> Cc: linux-fsdevel <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, David Howells <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, stable <firstname.lastname@example.org>, Android Kernel Team <email@example.com> Subject: Re: [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe Date: Fri, 30 Jul 2021 12:23:59 -0700 [thread overview] Message-ID: <CAHk-=wjStQurUzSAPVajL6Rj=CaPuSSgwaMO=0FJzFvSD66ACw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri, Jul 30, 2021 at 12:11 PM Sandeep Patil <email@example.com> wrote: > > Yes, your patch fixes all apps on Android I can test that include this > library. Ok, thanks for checking. > fwiw, the library seems to have been fixed. However, I am not sure > how long it will be for all apps to take that update :(. I wonder if I could make the wakeup logic do this only for the epollet case. I'll have to think about it, but maybe I'll just apply that simple patch. I dislike the pointless wakeups, and as long as the only case I knew of was only a test of broken behavior, it was fine. But now that you've reported actual application breakage, this is in the "real regression" category, and so I'll fix it one way or the other. And on the other hand I also have a slight preference towards your patch simply because you did the work of finding this out, so you should get the credit. I'll mull it over a bit more, but whatever I'll do I'll do before rc4 and mark it for stable. Thanks for testing, Linus
next prev parent reply other threads:[~2021-07-30 19:24 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 22:26 [PATCH 0/1] Revert change in pipe reader wakeup behavior Sandeep Patil 2021-07-29 22:26 ` [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe Sandeep Patil 2021-07-29 23:01 ` Linus Torvalds 2021-07-30 19:11 ` Sandeep Patil 2021-07-30 19:23 ` Linus Torvalds [this message] 2021-07-30 19:47 ` Sandeep Patil 2021-07-30 22:06 ` Linus Torvalds 2021-07-30 22:53 ` Linus Torvalds 2021-07-30 22:55 ` Linus Torvalds 2021-07-31 5:32 ` Greg Kroah-Hartman 2021-08-02 18:59 ` Sandeep Patil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHk-=wjStQurUzSAPVajL6Rj=CaPuSSgwaMO=0FJzFvSD66ACw@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).