From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
peterz@infradead.org, paulmck@kernel.org
Subject: Re: [GIT PULL] Final KVM fix for Linux 6.7
Date: Fri, 5 Jan 2024 09:38:22 -0800 [thread overview]
Message-ID: <CAHk-=wjc5x_Y=MX35vaoWodpfOU86_gm6BQTGWXgDeFMPneTrQ@mail.gmail.com> (raw)
In-Reply-To: <ZZg8kbb3-riiLbrb@google.com>
On Fri, 5 Jan 2024 at 09:29, Sean Christopherson <seanjc@google.com> wrote:
>
> Ha! That's what I suggested too, clearly Paolo is the weird one :-)
Well, it's technically one fewer operation to do it our way, but
Paolo's version is
(a) textually one character shorter
(b) something the compiler can (and likely will) munge anyway, since
boolean operation optimizations are common
(c) with the 'andn' instruction, the "fewer operations" isn't
necessarily fewer instructions
Of course, we can't currently use 'andn' in kernel code due to it
being much too new and requires BMI1. Plus the memory op version is
the wrong way around (ie the "not" part of the op only works on
register inputs), but _evenbtually_ that might have been an argument.
Linus
next prev parent reply other threads:[~2024-01-05 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 15:48 [GIT PULL] Final KVM fix for Linux 6.7 Paolo Bonzini
2024-01-05 17:21 ` Linus Torvalds
2024-01-05 17:29 ` Sean Christopherson
2024-01-05 17:35 ` Paolo Bonzini
2024-01-05 17:38 ` Linus Torvalds [this message]
2024-01-05 18:10 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjc5x_Y=MX35vaoWodpfOU86_gm6BQTGWXgDeFMPneTrQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).