From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4224DC43603 for ; Sun, 15 Dec 2019 19:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BD0A24676 for ; Sun, 15 Dec 2019 19:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576439468; bh=0nTZVgDcHcVMP7hjh1rqobxx8FreEcj1+ED5i/y/QRQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=osu/eGjoqWage48qZMsphsazegGjpd6/I+gbdQzP8SLYmZZnh4aoZLjtRgzlOyX68 LrpKWe/J9X1OWJRwOaJrzdgicWUVM4DVJ0fNNY+mxbN7Pg/K7CYnvc/fFk4NYnWSg6 Izy1Khl2dUxu0Gvat/u1aSx7DOPnxyr0EWnAwVFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfLOTvH (ORCPT ); Sun, 15 Dec 2019 14:51:07 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43441 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfLOTvG (ORCPT ); Sun, 15 Dec 2019 14:51:06 -0500 Received: by mail-lj1-f195.google.com with SMTP id a13so4361113ljm.10 for ; Sun, 15 Dec 2019 11:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N6ga5Dij19gRlbZuFsvjV48za8B/ozUT+pF6pWHLfdc=; b=EKgmCh3VQlwvNo2cKRez+F2dNTyhNipLcOxSlHHRddG2LPsdMyWZ6gjxZifjjL8Nrg GsrGGw/+RTAmX49CoqvKLZPmgeHNho5AnGcp+OhZDacyAnfwqFDiKiWkMI0W+QLHLAJW 60XKpY2owTpOLSh8k/lLAJHpqBQY1EHpkjfgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N6ga5Dij19gRlbZuFsvjV48za8B/ozUT+pF6pWHLfdc=; b=SC0Jxu5XYMM251ZHGjWw2EqRAdc3UpE9AV1QTUwhE6zgBlE0SFYnB21rIXwnP0H0q1 AmcwVM+3d1sNHxjcqv5g5AfXQjEjlAZpPSCIwHgDiLUc2+o9IUpl+bYoTCh6JNmT3yhC vLqvFJIw/cv8qb75BcHfuUQGSUrIcETHEJ20A/SprAKVXACDC4/y4mYtkFU2pTh9XtpR KMqRQoygN7Sw3aPZld7hFeuompc0h01wJi9wp+7Qo2nJ09t8/GbMrPsrYQe4fgIqrZly ADu7h+z4yDdFJnKNSdkae/njujJRPPs6dLeIjMzdRkW1Qy4ah2LMAffeMCZSSTrIJKiw EXgQ== X-Gm-Message-State: APjAAAVjntUip1+t6LUUYgmj8nkOroW305dMGEDnV3TEIh2iabvsmPmq RNpq6udyWPsYi9rTyBgFItnQhGqxy20= X-Google-Smtp-Source: APXvYqxoxstUFr7MJqNRedCNQQRBCqDI0Oqtt5tgHkpsfWgR8Vuu0Cl8hO616K0xB9exC2Ls0zmpnA== X-Received: by 2002:a2e:b4cb:: with SMTP id r11mr16976229ljm.68.1576439464441; Sun, 15 Dec 2019 11:51:04 -0800 (PST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id m8sm8952801ljc.16.2019.12.15.11.51.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Dec 2019 11:51:03 -0800 (PST) Received: by mail-lj1-f179.google.com with SMTP id e10so4389174ljj.6 for ; Sun, 15 Dec 2019 11:51:03 -0800 (PST) X-Received: by 2002:a2e:99d0:: with SMTP id l16mr17333620ljj.1.1576439462915; Sun, 15 Dec 2019 11:51:02 -0800 (PST) MIME-Version: 1.0 References: <20191212181422.31033-1-linux@dominikbrodowski.net> In-Reply-To: <20191212181422.31033-1-linux@dominikbrodowski.net> From: Linus Torvalds Date: Sun, 15 Dec 2019 11:50:46 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] remove ksys_mount() and ksys_dup() To: Dominik Brodowski Cc: Alexander Viro , Greg Kroah-Hartman , "Rafael J . Wysocki" , Andrew Morton , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 10:14 AM Dominik Brodowski wrote: > > the fifth parameter (void *data) > is either NULL or refers to a full page (only occurence > in init/do_mounts.c::do_mount_root()). We probably should aim for the fifth parameter being a "buf, len" pair at some point. Then the system call interface still needs to copy the whole page and pass in PAGE_SIZE as the length, but it would be a better model than the magical fixed "it's always one page". And the kernel init sequence wouldn't need that silly temporary page any more. Linus