From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B24CC04AB3 for ; Mon, 27 May 2019 19:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9F5C20883 for ; Mon, 27 May 2019 19:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558985252; bh=oV+Tr72EVh035Z7dNTsIRGgVfG28+FXQqpj2Pkxp0TE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=kRG0MaoWjEZ2r67LEa/iDUurre5THyQ74LuBbpfrF53XuBqaDQfPnNGkUG7T3S07m bpQFterua0en2XFsfdq6Luj3u+1v2oWeZyo4T8i9sumb/OwCTyfwqSV9JN3cAlRZgc tV/UfUV8KdNjcS3g9VUfmsnttt+9PO3nQVlsYH7c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfE0T1b (ORCPT ); Mon, 27 May 2019 15:27:31 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:39226 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfE0T1a (ORCPT ); Mon, 27 May 2019 15:27:30 -0400 Received: by mail-lj1-f196.google.com with SMTP id a10so4750237ljf.6 for ; Mon, 27 May 2019 12:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wd78z65uwhoM3ZRJNvBK+0h0z7TF6bqVWxLdc1NV2X4=; b=LGnbuv9FuD6KUsqZha7QN8hFiUBO8xRgmaS45CB4OxnREfVukEvDCgYO5N/0PHXnGF 5h9pdEEPPY+noavybWPcq177D/0MwCxHqGQO/kg9yHPrJJjqZW0W1OmvLZZuVocaYAoe MsjOXzqUVioxHYj9DO5Ltrrc2cXtDVvivTa/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wd78z65uwhoM3ZRJNvBK+0h0z7TF6bqVWxLdc1NV2X4=; b=RwwguE8f132a5a/qI8bSjgxBLFFX++KMY08UMRWYfE7APWkd6lX9Re4SDFcJL7DXi0 46HwktYSat+xCf+nRG58ko6g/M/tXxtOG+HKLonkZlKmOssbtMveKI4BHoIGRJIULr1Z Ih6VEHl8bLXCd0LlpfftbknP8ylUzDwt6BRcT2v4JApGt3BmtvPO+yVxpIj5DjL/ad8A 1CgfZK9j1fSyiTgTDEG++nrtmIT50YXgqVifq0viVca8Wt0sRhDNMmDieRV3XN0m+vAs dzngOZ4BGgTnHJIGjDoO8VoKNsGw9cTOASL4BzAaOnhhWZ7Tv8eusXmkzeWtc8T/QTl4 w5UQ== X-Gm-Message-State: APjAAAWhj5QopmIGTdTV4iSMU09EHtfDsvS88xKU+gwqhZUs6kJY5gzO QhD1wT97mxevTJJ/pIKmkdGSO85KWZU= X-Google-Smtp-Source: APXvYqwZNCzwe6+YrD81HHbqX/ln5VchGhtvtQSgHmD8ssDatacOxikMZyglweYEF5pfNFSKnbk9NQ== X-Received: by 2002:a2e:3e14:: with SMTP id l20mr46509816lja.40.1558985248443; Mon, 27 May 2019 12:27:28 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id 12sm2475689ljf.12.2019.05.27.12.27.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 12:27:25 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id 14so15552252ljj.5 for ; Mon, 27 May 2019 12:27:24 -0700 (PDT) X-Received: by 2002:a2e:97d8:: with SMTP id m24mr52565527ljj.52.1558985244303; Mon, 27 May 2019 12:27:24 -0700 (PDT) MIME-Version: 1.0 References: <20190526102612.6970-1-christian@brauner.io> <20190527104239.fbnjzfyxa4y4acpf@brauner.io> In-Reply-To: <20190527104239.fbnjzfyxa4y4acpf@brauner.io> From: Linus Torvalds Date: Mon, 27 May 2019 12:27:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] fork: add clone6 To: Christian Brauner Cc: Al Viro , Linux List Kernel Mailing , Jann Horn , Florian Weimer , Oleg Nesterov , Arnd Bergmann , David Howells , Pavel Emelyanov , Andrew Morton , Adrian Reber , Andrei Vagin , Linux API Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 27, 2019 at 3:42 AM Christian Brauner wrote: > > Hm, still pondering whether having one unsigned int argument passed > through registers that captures all the flags from the old clone() would > be a good idea. That sounds like a reasonable thing to do. Maybe we could continue to call the old flags CLONE_XYZ and continue to pass them in as "flags" argument, and then we have CLONE_EXT_XYZ flags for a new 64-bit flag field that comes in through memory in the new clone_args thing? That would make the flag arguments less "unified", but might make for a simpler patch, and might make it easier for the old interfaces to just pass in the clone flags they already have in registers instead of setting them up in the clone_args structure. I don't think it's necessarily wrong for the interface to show some effects of legacy models, as long as we don't have those kinds of "if (is_clone6)" nasties. Linus