From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C083C43603 for ; Fri, 6 Dec 2019 21:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D41921835 for ; Fri, 6 Dec 2019 21:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575666264; bh=7+C/syog45uVTp76fUkO4osOOUY/e5NQqB0R1Qj2uuo=; h=References:In-Reply-To:From:Date:Subject:To:List-ID:From; b=C7buZCBCqlqGix9La1ha8rSkOyeaPd+S+cdDX2N7QxIl2lvOoqBEoi5KB5uFeyP3Y yfLOg1g6bGm1Ud/wtm6wuY79GQsRd0LxTOD/ZceUJwQBt6Y1+NSeiYEivSp7nqWFCE KAWZOf1XFtvCWrtg6n8iAPHMJ7vTgOyFSs4HRUxw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726414AbfLFVEX (ORCPT ); Fri, 6 Dec 2019 16:04:23 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:42170 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfLFVEW (ORCPT ); Fri, 6 Dec 2019 16:04:22 -0500 Received: by mail-lf1-f68.google.com with SMTP id y19so6257951lfl.9 for ; Fri, 06 Dec 2019 13:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=N5jNUqI0VTnKojC60LXRRrRCF9Kd4ozDJywm8qVH48M=; b=T+F3Xq2tjKRjrpZcEc6t7v18sftYeucO7ZyPfPqQ7tM6q9iFLFGbCuoWlfRY2Hzk+l and8v+JEwpmdnyVjXGn1FM2unB92WIhz/EloPMLQdj9o+Xf4HI4y417R0xUXJs8RO1y7 xFw7J7L1qfI8JtZHgrkuKl3lKoLBh5eEnA5I0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=N5jNUqI0VTnKojC60LXRRrRCF9Kd4ozDJywm8qVH48M=; b=iHJw3+2Om3PJ5/zDEXrTY9o+Hoc/TCuxktfDVkKh+hU4oYDqR11gra9dAU796M+Hre O9X8KtbAqJ0c2Dm0BmzPtt6581YjkLKKPQ2aiHaJNcgotjQ0OOQq3H9+YgrNJD6Hymol cP6VYlGgHD7wU1gFbdnXLFR4q5aGOo2d64BIhT0oRU0lkCfy+JiPHMnj2AV6PtYAkgTi wu5XAtNzZXcjgWFQIlWlq9T9+rL1s4WtZircrpmQb2qo77X8KIdaNIP/K5vASPYqAzre FkFp57EKdJLIMMOLdX3cPErFfXD2ZwKg2Gu7mm2VvKa8upl2sUH+ZQ6UcrnTKxRLjd8D Y28A== X-Gm-Message-State: APjAAAUt2fS65tIy1Op9QLmePSBVWW+ELLSwQZoivRksH54uNyzjlvZj 62ZKFjY/3exCiPiBIlB4DJnSkGFu1Mk= X-Google-Smtp-Source: APXvYqwXIkZd3sT+5LEPI8zvkMPHHS9JAbNOL4aWyaGLiSmoTR2w4zIQE625dItT2d/ezYl28VniBA== X-Received: by 2002:a05:6512:15d:: with SMTP id m29mr9415504lfo.51.1575666259419; Fri, 06 Dec 2019 13:04:19 -0800 (PST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id s16sm1665120lfc.35.2019.12.06.13.04.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Dec 2019 13:04:18 -0800 (PST) Received: by mail-lj1-f177.google.com with SMTP id 21so9152060ljr.0 for ; Fri, 06 Dec 2019 13:04:18 -0800 (PST) X-Received: by 2002:a05:651c:239:: with SMTP id z25mr7532335ljn.48.1575666257943; Fri, 06 Dec 2019 13:04:17 -0800 (PST) MIME-Version: 1.0 References: <157558502272.10278.8718685637610645781.stgit@warthog.procyon.org.uk> <20191206135604.GB2734@twin.jikos.cz> In-Reply-To: From: Linus Torvalds Date: Fri, 6 Dec 2019 13:04:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] pipe: Fixes [ver #2] To: David Sterba , David Howells , Linus Torvalds , Eric Biggers , Al Viro , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 6, 2019 at 12:28 PM Linus Torvalds wrote: > > I think I found it. > > TOTALLY UNTESTED patch appended. It's whitespace-damaged and may be > completely wrong. And might not fix it. Well, it compiles, and it's obviously correct, so I've committed it. It doesn't fix my "kernel compiles go single-threaded" issue. Which is not surprising - make doesn't use splice(), it just reads and writes single characters (the main make server writes a "+" character for each available job, and parallel sub-makes will read one for each job they start and write one when done - or something very close to that). I think that is related to the other pipe changes, though - there were some wakeup changes in there too. The btrfs problem was bisected to the original commit, which is what I think my patch fixes. Linus